https://bugzilla.redhat.com/show_bug.cgi?id=2150036
Bug ID: 2150036 Summary: Review Request: perl-Alien-Font-Uni - Access to Unifont truetype file Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni-0.3-... Description: This module was created as an optional dependency of Chart to have access to a Unicode-complete scaleable font file. Thus only the Unifont TTF file is provided since this is what GD can read.
Fedora Account System Username: ppisar
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mspacek@redhat.com Assignee|nobody@fedoraproject.org |mspacek@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #1 from Michal Josef Spacek mspacek@redhat.com --- There are some issues: * Alien::Font::Uni wants *ttf files, but unifont-fonts delivers *otf fonts (which is installed by 'font(unifont)'. There is unifont-ttf-fonts package. * Remove "File::ShareDir::Install" => "0.06" from configure options in Makefile.PL by existing patch * Remove BuildRequires with COMPAT
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
--- Comment #2 from Petr Pisar ppisar@redhat.com --- Thanks for highlighting the issues. All should be addressed now.
Spec URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni-0.3-...
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Michal Josef Spacek mspacek@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-Alien-Font-Uni-0.3-1.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl-libs 1 perl(strict) 1 perl(version) >= 0.77 1 unifont-ttf-fonts Binary requires are Ok.
$ rpm -qp --provides perl-Alien-Font-Uni-0.3-1.fc39.noarch.rpm | sort | uniq -c 1 perl(Alien::Font::Uni) = 0.3 1 perl-Alien-Font-Uni = 0.3-1.fc39 Binary provides are Ok.
$ rpmlint ./perl-Alien-Font-Uni* 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s perl-Alien-Font-Uni-tests.noarch: W: no-documentation Rpmlint is ok
The package is in line with Fedora and Perl packaging guide lines.
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-Font-Uni
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Fixed In Version| |perl-Alien-Font-Uni-0.3-1.f | |c39
--- Comment #5 from Petr Pisar ppisar@redhat.com --- Thank you for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=2150036
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-05-25 11:06:27
package-review@lists.fedoraproject.org