Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: wadofstuff-django-serializers - Extended Django Serializer Module
https://bugzilla.redhat.com/show_bug.cgi?id=728826
Summary: Review Request: wadofstuff-django-serializers - Extended Django Serializer Module Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: yuwang@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://yuwang.fedorapeople.org/wadofstuff-django-serializers.spec
Description: The wadofstuff.django.serializers python module extends Django's built-in serializers, adding 3 new capabilities inspired by the Ruby on Rails JSON serializer. These parameters allow the developer more control over how their models are serialized. The additional capabilities are:
excludes - a list of fields to be excluded from serialization. The excludes list takes precedence over the fields argument. extras - a list of non-model field properties or callables to be serialized. relations - a list or dictionary of model related fields to be followed and serialized.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
Yuguang Wang yuwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dli@redhat.com, | |petersen@redhat.com, | |rhe@redhat.com, | |vchen@redhat.com, | |yuwang@redhat.com Blocks| |177841(FE-NEEDSPONSOR)
--- Comment #1 from Yuguang Wang yuwang@redhat.com 2011-08-07 23:24:26 EDT --- [yuwang@yuwang wadofstuff-django-serializers-1.1.0]$ rpmlint wadofstuff-django-serializers.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
Yuguang Wang yuwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |690728
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #2 from Jens Petersen petersen@redhat.com 2011-08-19 02:38:49 EDT --- Could you please post an srpm?
You need to include the release number in changelog entries:
wadofstuff-django-serializers.noarch: W: incoherent-version-in-changelog 1.1.0 ['1.1.0-1.fc15', '1.1.0-1']
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #3 from Yuguang Wang yuwang@redhat.com 2011-08-22 03:17:18 EDT --- Wow, warning not allowed. Spec file updated: http://yuwang.fedorapeople.org/wadofstuff-django-serializers.spec
rpmlint ok: [yuwang@yuwang wadofstuff-django-serializers-1.1.0]$ rpmlint wadofstuff-django-serializers-1.1.0-1.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. (In reply to comment #2)
Could you please post an srpm?
You need to include the release number in changelog entries:
wadofstuff-django-serializers.noarch: W: incoherent-version-in-changelog 1.1.0 ['1.1.0-1.fc15', '1.1.0-1']
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #4 from Jens Petersen petersen@redhat.com 2011-08-22 20:26:00 EDT --- Thanks and where is the srpm?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #5 from Yuguang Wang yuwang@redhat.com 2011-08-23 00:57:59 EDT --- Uploaded in fedorapeople, rpm built in fedora 13: http://yuwang.fedorapeople.org/wadofstuff-django-serializers-1.1.0-1.fc13.sr...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #6 from Jens Petersen petersen@redhat.com 2011-09-02 05:13:24 EDT --- Thanks - as I mentioned also in bug 728823 please don't repackage the source tarball. We don't do that in Fedora, but always ship pristine source (which can be patched via rpm if necessary.) Adding the .spec is also kind of meaningless since it is already in the src.rpm anyway and will change each time you update the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #7 from Jens Petersen petersen@redhat.com 2011-09-29 03:13:43 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #8 from Yuguang Wang yuwang@redhat.com 2011-09-29 23:15:27 EDT --- Package updated: http://yuwang.fedorapeople.org/wadofstuff-django-serializers.spec http://yuwang.fedorapeople.org/wadofstuff-django-serializers-1.1.0-1.fc13.sr...
rpmlint wadofstuff-django-serializers-1.1.0-1.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #9 from Parag AN(पराग) panemade@gmail.com 2011-11-21 01:02:00 EST --- Review:
+ koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3528874
+ rpmlint on rpms gave wadofstuff-django-serializers.noarch: W: install-file-in-docs /usr/share/doc/wadofstuff-django-serializers-1.1.0/INSTALL 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ source match with upstream as (sha1sum) cef278159d28d235b4eb06bc4b7864b9d9a8a9ed wadofstuff-django-serializers-1.1.0.tar.gz cef278159d28d235b4eb06bc4b7864b9d9a8a9ed ../SOURCES/wadofstuff-django-serializers-1.1.0.tar.gz
+ Follows packaging guidelines.
suggestions: 1) we don't recommend to add INSTALL file as its only for manually installation from tarball. so remove that from spec.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #10 from Parag AN(पराग) panemade@gmail.com 2011-12-21 05:20:09 EST --- Can you request for SCM?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
Yuguang Wang yuwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #11 from Yuguang Wang yuwang@redhat.com 2011-12-21 21:24:49 EST --- New Package SCM Request ======================= Package Name: wadofstuff-django-serializers Short Description: Extended Django Serializer Module Owners: yuwang Branches: f15 f16 el6 InitialCC: yuwang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
--- Comment #12 from Jon Ciesla limburgher@gmail.com 2011-12-22 08:16:46 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
Yuguang Wang yuwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2011-12-23 04:54:03
--- Comment #13 from Yuguang Wang yuwang@redhat.com 2011-12-23 04:54:03 EST --- Koji build successfully.
F16: https://koji.fedoraproject.org/koji/taskinfo?taskID=3602719 el6: http://koji.fedoraproject.org/koji/taskinfo?taskID=3602733
Thanks all for your help.
https://bugzilla.redhat.com/show_bug.cgi?id=728826
Björn "besser82" Esser bjoern.esser@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
package-review@lists.fedoraproject.org