Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: foolish@guezz.net QAContact: fedora-package-review@redhat.com
Spec URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-DBIx-SQLite-Simple.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-DBIx-SQLite-Simple-0.34-1...
Description:
perl-DBIx-SQLite-Simple provides easy access to the SQLite databases using objects.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: perl-DBIx- |Review Request: perl-DBIx- |SQLite-Simple - Easy access|SQLite-Simple - Easy access |to SQLite databases using |to SQLite databases using |objects |objects BugsThisDependsOn| |239155
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |239164 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |DBIx-SQLite-Simple
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
------- Additional Comments From cweyl@alumni.drew.edu 2007-05-06 14:25 EST ------- Missing BR's on: perl(ExtUtils::MakeMaker) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage)
rpmlint complains about tabs/spaces -- this should be an easy fix.
Also, for a variety of reasons, this package should own the entire directory chain under %{perl_vendorlib}, e.g., not %{perl_vendorlib}/DBIx/SQLite/* but just %{perl_vendorlib}/*.
Correct the BR's, pacify rpmlint and correct %files and I'll approve :)
+ source files match upstream: 7375627800f0ef136eff5ef18c766c64 DBIx-SQLite-Simple-0.34.tar.gz 7375627800f0ef136eff5ef18c766c64 DBIx-SQLite-Simple-0.34.tar.gz.srpm + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text included in package. + latest version is being packaged. X BuildRequires are proper. + compiler flags are appropriate. (noarch) + %clean is present. X rpmlint is silent (see below) + final provides and requires are sane: ** perl-DBIx-SQLite-Simple-0.34-1.fc6.src.rpm W: perl-DBIx-SQLite-Simple mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) ** perl-DBIx-SQLite-Simple-0.34-1.fc6.noarch.rpm == rpmlint == provides perl(DBIx::SQLite::Simple) = 0.34 perl(DBIx::SQLite::Simple::Table) perl-DBIx-SQLite-Simple = 0.34-1.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Class::Gomor::Array) perl(DBI) perl(DBIx::SQLite::Simple) perl(strict) perl(warnings) + %check is present and all tests pass: All tests successful. Files=6, Tests=8, 1 wallclock secs ( 0.50 cusr + 0.14 csys = 0.64 CPU) + no shared libraries are added to the regular linker search paths. X owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |cweyl@alumni.drew.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
------- Additional Comments From foolish@guezz.net 2007-05-06 17:27 EST ------- Updated:
SPEC: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Class-Gomor.spec SRPM: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-Class-Gomor-1.01-2.fc7.sr...
Changes: - Add missing BRs - Add examples dir to %%doc
rpmlint is silent here, but it was silent before as well.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
------- Additional Comments From foolish@guezz.net 2007-05-06 17:29 EST ------- Bah! Ignore the last message:
SPEC: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-DBIx-SQLite-Simple.spec SRPM: http://folk.ntnu.no/sindrb/packages/green_nyc/perl-DBIx-SQLite-Simple-0.34-2...
Changes:
- Add missing BRs - Fix %%files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From cweyl@alumni.drew.edu 2007-05-07 10:26 EST ------- APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From foolish@guezz.net 2007-05-08 10:59 EST ------- New Package CVS Request ======================= Package Name: perl-SQLite-Simple Short Description: Easy Access to SQLite databases using objects Owners: foolish@guezz.net Branches: FC-5 FC-6 EL-4 EL-5 InitialCC: jaa@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From foolish@guezz.net 2007-05-11 10:46 EST ------- I botched the last one:
New Package CVS Request ======================= Package Name: perl-DBIx-SQLite-Simple Short Description: Easy Access to SQLite databases using objects Owners: foolish@guezz.net Branches: FC-5 FC-6 EL-4 EL-5 InitialCC: jaboutbo@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
Bug 239156 depends on bug 239155, which changed state.
Bug 239155 Summary: Review Request: perl-Class-Gomor - Another class and object builder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239155
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|NEXTRELEASE | Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From foolish@guezz.net 2007-05-23 11:03 EST ------- Seems the F7 branch wasn't created during merge, please add it.
New Package CVS Request ======================= Package Name: perl-DBIx-SQLite-Simple Short Description: Easy Access to SQLite databases using objects Owners: foolish@guezz.net Branches: FC-5 FC-6 EL-4 EL-5 F-7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From petersen@redhat.com 2007-05-27 00:46 EST ------- F-7 added
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
Bug 239156 depends on bug 239155, which changed state.
Bug 239155 Summary: Review Request: perl-Class-Gomor - Another class and object builder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239155
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution|NEXTRELEASE | Status|CLOSED |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239156
Bug 239156 depends on bug 239155, which changed state.
Bug 239155 Summary: Review Request: perl-Class-Gomor - Another class and object builder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239155
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-DBIx-SQLite-Simple - Easy access to SQLite databases using objects Alias: DBIx-SQLite-Simple
https://bugzilla.redhat.com/show_bug.cgi?id=239156
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org