[Bug 2335183] New: Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Bug ID: 2335183
           Summary: Review Request: golang-github-coder-websocket -
                    Minimal and idiomatic WebSocket library for Go
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://www.flyn.org/SRPMS/golang-github-coder-websocket.spec
SRPM URL:
https://www.flyn.org/SRPMS/golang-github-coder-websocket-1.8.12-1.fc41.src.r...
Description: Minimal and idiomatic WebSocket library for Go
Fedora Account System Username: mikep

This is a goipath change from golang-nhooyr-websocket.

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8462156
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Mikel Olasagasti Uranga  ---
Can you keep the *generate_buildrequires part, but remove the modules required
extra deps? Like this:
> %prep
> %goprep -A
> # Remove benchmark and examples to avoid extra deps
> rm -rf internal/examples internal/thirdparty
> %if %{without bootstrap}
> %generate_buildrequires
> %go_generate_buildrequires
> %endif

That way, if in the future it requires any module it should be easier to bump.

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

--- Comment #3 from W. Michael Petullo  ---
Spec URL: https://www.flyn.org/SRPMS/golang-github-coder-websocket.spec
SRPM URL:
https://www.flyn.org/SRPMS/golang-github-coder-websocket-1.8.12-1.fc41.src.r...
Description: Minimal and idiomatic WebSocket library for Go
Fedora Account System Username: mikep

Revised to follow comment #2.

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

--- Comment #4 from Fedora Review Service  ---
Created attachment 2064462
  --> https://bugzilla.redhat.com/attachment.cgi?id=2064462&action=edit
The .spec file difference from Copr build 8462156 to 8462299

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

--- Comment #5 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8462299
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #6 from Mikel Olasagasti Uranga  ---
Forgot to mention that the thirdparty %check part can be be removed. If you can
do it before importing would be great.

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The latest version is packaged or packaging an earlier version is
justified.
- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these
by default)
- [x] The package does not use `%gometa -f` if it has dependents that still
build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the
Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RELEASE_PENDING

--- Comment #7 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-coder-websocket

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #8 from Fedora Update System  ---
FEDORA-2025-ccedfad29b (golang-github-coder-websocket-1.8.12-2.fc42) has been
submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ccedfad29b

[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2025-01-01 23:04:51

--- Comment #9 from Fedora Update System  ---
FEDORA-2025-ccedfad29b (golang-github-coder-websocket-1.8.12-2.fc42) has been
pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.