https://bugzilla.redhat.com/show_bug.cgi?id=1448694
Bug ID: 1448694 Summary: Review Request: rubygem-json-schema - Ruby JSON Schema Validator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: valtri@civ.zcu.cz QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://scientific.zcu.cz/fedora/rubygem-json-schema-2.8.0-1/rubygem-json-sch... SRPM URL: http://scientific.zcu.cz/fedora/rubygem-json-schema-2.8.0-1/rubygem-json-sch... Description: Ruby JSON Schema Validator. Fedora Account System Username: valtri
COPR builds: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/548664/
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review?
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- Taking.
I would appreciate it if you would review my review request (bug 1448298)
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- One recommendation * I usually recommend to place "README.md" to main package, as it says "README", however this is up to your decision.
* license okay * source matches the upstream * spec file clean * koji build okay (F-27, F-26) * rpmlint clean * installation okay * basic functionality (taken from README.md) works.
$ ruby -e 'require "json-schema" ; schema = {"type"=>"object", "required"=>["a"], "properties"=>{"a"=>{"type"=>"integer"}}} ; p JSON::Validator.validate(schema, { "a" => 5 }) ; p JSON::Validator.validate(schema, { "a" => 4.3 })' true false
===================================================== This package (rubygem-json-schema) is APPROVED by mtasaka =====================================================
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-json-schema
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- rubygem-json-schema-2.8.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e08c3c0474
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- rubygem-json-schema-2.8.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2290ea410a
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- rubygem-json-schema-2.8.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e08c3c0474
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rubygem-json-schema-2.8.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2290ea410a
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-05-27 19:26:02
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-json-schema-2.8.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1448694
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-json-schema-2.8.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org