Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190304
Summary: Review Request: mtd-utils Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: dwmw2@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: ftp://ftp.infradead.org/pub/mtd-utils/mtd-utils.spec SRPM URL: ftp://ftp.infradead.org/pub/mtd-utils/mtd-utils-1.0.0-1.src.rpm Description: Utilities for dealing with MTD (flash) devices.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mtd-utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190304
jwboyer@jdub.homelinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |jwboyer@jdub.homelinux.org OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From jwboyer@jdub.homelinux.org 2006-05-01 11:57 EST ------- I'll review this tonight. At first glance, it seems fine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mtd-utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190304
jwboyer@jdub.homelinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jwboyer@jdub.homelinux.org |dwmw2@redhat.com OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From jwboyer@jdub.homelinux.org 2006-05-01 20:18 EST ------- Completed MUST items:
- rpmlint output:
[jwboyer@vader i386]$ rpmlint -v mtd-utils-1.0.0-1.i386.rpm I: mtd-utils checking [jwboyer@vader i386]$
- named according to the Package Naming guidlines - spec file name matches %{name}.spec - meets Packaging Guidelines - licensed under the GPL - License: field matches - MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. - source SHA1 sum matches upstream - compiles and builds on x86
Two small nits:
- The package should probably throw a Requires: zlib and BuildRequires: zlib-devel in the spec file. - The upstream source lacks a copy of the license text. It would be nice if the upstream source could include this at some point, but is not required.
I'm assuming David will fixup the zlib issues. After that is done, I consider this approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mtd-utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190304
dwmw2@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From dwmw2@redhat.com 2006-05-02 08:30 EST ------- Added BuildRequires: zlib-devel Added COPYING (and also upstream from your git tree) Not added Requires: zlib since that's automatic. Imported and built. Thanks.
package-review@lists.fedoraproject.org