Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
Summary: Review Request: perl-XML-Stream Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
Spec URL: http://home.comcast.net/~ckweyl/perl-XML-Stream.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-XML-Stream-1.22-1.fc5.src.rpm Description:
This module provides the user with methods to connect to a remote server, send a stream of XML to the server, and receive/parse an XML stream from the server. It is primarily based work for the Etherx XML router developed by the Jabber Development Team. For more information about this project visit http://etherx.jabber.org/stream/.
XML::Stream gives the user the ability to define a central callback that will be used to handle the tags received from the server. These tags are passed in the format defined at instantiation time. the closing tag of an object is seen, the tree is finished and passed to the call back function. What the user does with it from there is up to them.
For a detailed description of how this module works, and about the data structure that it returns, please view the source of Stream.pm and look at the detailed description at the end of the file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |191540
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|191540 | OtherBugsDependingO| |191540 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From cweyl@alumni.drew.edu 2006-05-15 10:33 EST ------- Updated: Spec URL: http://home.comcast.net/~ckweyl/perl-XML-Stream.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-XML-Stream-1.22-2.fc5.src.rpm
Additionally, with respect to licensing, the author indicates that perl (GPL & Artistic) is the correct license:
Date: Sun, 14 May 2006 16:52:31 -0500 From: Ryan Eatmon reatmon@jabber.org To: Chris Weyl cweyl@alumni.drew.edu Subject: Re: Net::XMPP license question
Yep.
Chris Weyl wrote:
Hey Ryan--
Quick question. I'm in the middle of packaging up Net::XMPP (and for that matter, XML::Stream and Net::Jabber) for fedora extras, and it was pointed out to me that while Net/XMPP.pm states "COPYRIGHT: This module is free software, you can redistribute it and/or modify it under the same terms as Perl itself", the actual archive includes a LICENSE.LGPL.
Are all three of these modules under "the same terms as Perl itself"?
Thanks:) -Chris
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From tibbs@math.uh.edu 2006-05-15 10:51 EST ------- Did the author have anything at all to say about the large copyright blocks on the code itself? The fact that this conflicts both the copyright statements in the documentation and seemingly the author's intent is disturbing. It might even make the software non-distributable.
I really think the author needs to release an update where everything agrees, or explicitly gives you permision to patch out the conflicting license statements and delete COPYING.LGPL. Sorry.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From cweyl@alumni.drew.edu 2006-05-15 11:00 EST ------- Author emailed, asking for permission to patch out and remove LGPL and statemente.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From tibbs@math.uh.edu 2006-05-22 15:11 EST ------- Any response from the author on any of these?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From cweyl@alumni.drew.edu 2006-05-22 21:13 EST ------- From: Ryan Eatmon reatmon@jabber.org To: Chris Weyl cweyl@alumni.drew.edu Date: May 22, 2006 6:03 PM Subject: Re: Net::XMPP license question
Whatever. I don't actually care one way or the other. Go right ahead.
Chris Weyl wrote:
Sorry to keep on bugging you, but would it be OK for me to strip out the LGPL licensing statements?
Or is this software triple licensed? e.g. Perl (GPL or Artistic), LGPL?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From cweyl@alumni.drew.edu 2006-05-24 11:48 EST ------- Updated to indicate the module is triple licensed: Perl (Artistic / GPL) & LGPL
Spec URL: http://home.comcast.net/~ckweyl/perl-XML-Stream.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-XML-Stream-1.22-3.fc5.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From tibbs@math.uh.edu 2006-05-25 23:16 EST ------- Note: test suites should not talk to the network as you don't know that the build hosts aren't completely firewalled. In any case, the tests don't work at all for me in mock, probably due to not having a resolver configuration:
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/buildxml......Cannot resolve compute20.math.uh.edu: at lib/XML/Stream.pm line 406. # Looks like you planned 56 tests but only ran 1. # Looks like your test died just after 1.
My recommendation is to just comment out the "make test" line in %check before you check in. I'll assume that's been done for the purposes of this review.
Upstream includes a copy of the LGPL, which you must include in the package. I would recommend including the others as well; just do
perldoc perlgpl > LICENSE.GPL perldoc perlartistic > LICENSE.Artistic
and then include those as %doc along with the included LICENSE.LGPL.
I'd also suggest including any correspondence with the author you have which might clarify the license issie.
No need to BuildRequires: perl, but not a blocker.
Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. O license field matches the actual license (please include the author's "clarification" of the license issue). X license is open source-compatible. License text provided but not included. * source files match upstream: ae09400fac17eaea4c9b12283db06881 XML-Stream-1.22.tar.gz ae09400fac17eaea4c9b12283db06881 XML-Stream-1.22.tar.gz-srpm * latest version is being packaged. O BuildRequires are proper. (perl BR is superfluous.) * package builds in mock (development, x86_64), with test suite disabled. * rpmlint is silent. * final provides and requires are sane: perl(XML::Stream) = 1.22 perl(XML::Stream::Namespace) = 1.22 perl(XML::Stream::Node) = 1.22 perl(XML::Stream::Parser) = 1.22 perl(XML::Stream::Parser::DTD) = 1.22 perl(XML::Stream::Tree) = 1.22 perl(XML::Stream::XPath) = 1.22 perl(XML::Stream::XPath::AllOp) perl(XML::Stream::XPath::AndOp) perl(XML::Stream::XPath::AttributeOp) perl(XML::Stream::XPath::ContextOp) perl(XML::Stream::XPath::EqualOp) perl(XML::Stream::XPath::FunctionOp) perl(XML::Stream::XPath::NodeOp) perl(XML::Stream::XPath::NotEqualOp) perl(XML::Stream::XPath::Op) = 1.22 perl(XML::Stream::XPath::OrOp) perl(XML::Stream::XPath::PositionOp) perl(XML::Stream::XPath::Query) = 1.22 perl(XML::Stream::XPath::Value) = 1.22 perl-XML-Stream = 1.22-3.fc6 - perl >= 0:5.006_001 perl(:MODULE_COMPAT_5.8.8) perl(Authen::SASL) perl(Carp) perl(Encode) perl(Exporter) perl(FileHandle) perl(IO::Select) perl(IO::Socket) perl(MIME::Base64) perl(POSIX) perl(Sys::Hostname) perl(XML::Stream::Namespace) perl(XML::Stream::Parser) perl(XML::Stream::XPath) perl(XML::Stream::XPath::Op) perl(XML::Stream::XPath::Query) perl(XML::Stream::XPath::Value) perl(strict) perl(utf8) perl(vars) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present but necessarily disabled. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
------- Additional Comments From cweyl@alumni.drew.edu 2006-05-25 23:45 EST ------- Updated as requested.
Spec URL: http://home.comcast.net/~ckweyl/perl-XML-Stream.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-XML-Stream-1.22-4.fc5.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-05-27 01:10 EST ------- OK, everything looks good; the package builds fine without changes and the license issue is as clear as we can make it.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Stream
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191523
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2006-06-04 00:37 EST ------- Built for devel, FE-4, FE-5. Thanks for the review! :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=191523
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@bachelot.org Flag| |fedora-cvs?
--- Comment #12 from Xavier Bachelot xavier@bachelot.org 2009-07-17 18:17:17 EDT --- Chris is ok with me taking the EL branches : https://bugzilla.redhat.com/show_bug.cgi?id=496891
Package Change Request ====================== Package Name: perl-XML-Stream New Branches: EL-5 Owners: xavierb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=191523
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #13 from Kevin Fenzi kevin@tummy.com 2009-07-19 16:57:07 EDT --- cvs done.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla