[Bug 676608] New: Review Request: rubygem-delayed_job - Database-backed asynchronous priority queue system -- Extracted from Shopify
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-delayed_job - Database-backed asynchronous priority queue system -- Extracted from Shopify
https://bugzilla.redhat.com/show_bug.cgi?id=676608
Summary: Review Request: rubygem-delayed_job - Database-backed asynchronous priority queue system -- Extracted from Shopify Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: vondruch@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://people.redhat.com/vondruch/rubygem-delayed_job.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-delayed_job-2.1.3-1.fc14.src.rpm
Description: Delayed_job (or DJ) encapsulates the common pattern of asynchronously executing longer tasks in the background. It is a direct extraction from Shopify where the job table is responsible for a multitude of core tasks. This gem is collectiveidea's fork (http://github.com/collectiveidea/delayed_job).
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2829503
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676608
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmorsi@redhat.com AssignedTo|nobody@fedoraproject.org |mmorsi@redhat.com
--- Comment #1 from Mo Morsi mmorsi@redhat.com 2011-07-21 15:30:13 EDT --- Taking this one. Overall looks good
- the latest upstream release is 2.1.4, please consider updating
- could you remove references in the summary / description to 'shopify'
- the rspec2 components are now in fedora, can we drop the patch to the spec suite?
- there is one rpmlint warning to note: rubygem-delayed_job.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/delayed_job-2.1.3/lib/generators/delayed_job/templates/script 0644L /usr/bin/env
- defaultattr is no longer necessary in files section an should be removed
- the package should own the %dir %{geminstdir} should it not
Package builds fine in koji.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676608
--- Comment #2 from Vít Ondruch vondruch@redhat.com 2011-07-25 07:45:27 EDT --- I have uploaded updated version of delayed_job:
Spec URL: http://people.redhat.com/vondruch/rubygem-delayed_job.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-delayed_job-2.1.4-1.fc16.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3227264
(In reply to comment #1)
Taking this one. Overall looks good
- the latest upstream release is 2.1.4, please consider updating
done
- could you remove references in the summary / description to 'shopify'
done
- the rspec2 components are now in fedora, can we drop the patch to the spec
suite?
done
- there is one rpmlint warning to note:
rubygem-delayed_job.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/delayed_job-2.1.3/lib/generators/delayed_job/templates/script 0644L /usr/bin/env
Actually this is Rails generator template, therefore it contains shebang, while it is not intended to be executed from current location, so the error is false positive.
- defaultattr is no longer necessary in files section an should be removed
done
- the package should own the %dir %{geminstdir} should it not
done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676608
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #3 from Mo Morsi mmorsi@redhat.com 2011-07-25 12:59:13 EDT --- Looks good. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676608
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Vít Ondruch vondruch@redhat.com 2011-07-26 04:19:16 EDT --- Thank you for your review!
New Package SCM Request ======================= Package Name: rubygem-delayed_job Short Description: Database-backed asynchronous priority queue system Owners: vondruch Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676608
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2011-07-26 06:06:09 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676608
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-07-26 07:11:23
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla