Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: annogen - Java framework for JSR-175 annotations
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Summary: Review Request: annogen - Java framework for JSR-175 annotations Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: agrimm@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Name : annogen Version : 0.1.0 License : ASL 2.0 URL : http://annogen.codehaus.org/ Summary : Java framework for JSR-175 annotations Description : Annogen is a framework which helps you work with JSR175 Annotations. In a nutshell, Annogen generates a proxy layer in front of your Annotations.
SPEC: http://downloads.eucalyptus.com/devel/packages/fedora-17/SPECS/annogen.spec
SRPM: http://downloads.eucalyptus.com/devel/packages/fedora-17/sources/annogen-0.1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Andy Grimm agrimm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183(FE-JAVASIG)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mgoldman@redhat.com AssignedTo|nobody@fedoraproject.org |mgoldman@redhat.com Flag| |fedora-review?
--- Comment #1 from Marek Goldmann mgoldman@redhat.com 2012-03-10 17:26:54 EST --- I'll take it and appreciate swap review of https://bugzilla.redhat.com/show_bug.cgi?id=791323
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
--- Comment #2 from Marek Goldmann mgoldman@redhat.com 2012-03-10 17:45:48 EST --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Rpmlint output:
$ rpmlint SPECS/annogen.spec SPECS/annogen.spec: W: invalid-url Source0: annogen-0.1.0.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint SRPMS/annogen-0.1.0-1.fc17.src.rpm annogen.src: I: enchant-dictionary-not-found en_US annogen.src: W: invalid-url Source0: annogen-0.1.0.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: ASL 2.0 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 6c08dd6ec71f126bf69dd29fada504cc MD5SUM upstream package: 4e9cf42125dfe672dda153ad52cb7c3e
SVN export.
[x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [!] Package contains code, or permissable content.
See #1.
[-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building
Removed, but please note #1 as this is a SVN export, not an upstream distribution.
[x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap
=== Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro
=== Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. Tested on:
https://koji.fedoraproject.org/koji/taskinfo?taskID=3879195
=== Issues === 1. Please remove all the jars at the time of export and create a rename the source distribution adding "-CLEAN" (preferred) at the end. 2. While copying javadocs; is "cp -rp build/docs", should be "cp -rp build/docs/*".
find annogen-0.1.0/ -name '*.jar' -delete
Btw, it's awesome that they ship version 0.1.1 under 0.1.0 tag :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
--- Comment #3 from Andy Grimm agrimm@gmail.com 2012-03-11 11:31:01 EDT --- Fixed:
SPEC: http://downloads.eucalyptus.com/devel/packages/fedora-17/SPECS/annogen.spec
SRPM: http://downloads.eucalyptus.com/devel/packages/fedora-17/sources/annogen-0.1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183(FE-JAVASIG) | Flag|fedora-review? |fedora-review+
--- Comment #4 from Marek Goldmann mgoldman@redhat.com 2012-03-12 03:49:45 EDT --- ================ *** APPROVED *** ================
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Andy Grimm agrimm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Andy Grimm agrimm@gmail.com 2012-03-12 08:22:19 EDT --- New Package SCM Request ======================= Package Name: annogen Short Description: Java framework for JSR-175 annotations Owners: arg Branches: f17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2012-03-12 08:59:19 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2012-03-12 10:52:43 EDT --- annogen-0.1.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/annogen-0.1.0-2.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2012-03-12 15:09:51 EDT --- annogen-0.1.0-2.fc17 has been pushed to the Fedora 17 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790990
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |annogen-0.1.0-2.fc17 Resolution| |ERRATA Last Closed| |2012-03-16 17:12:30
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2012-03-16 17:12:30 EDT --- annogen-0.1.0-2.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla