[Bug 1898470] New: [Unretirement] Review Request: nodejs-object-assign - ES6 Object.assign() ponyfill
https://bugzilla.redhat.com/show_bug.cgi?id=1898470
Bug ID: 1898470 Summary: [Unretirement] Review Request: nodejs-object-assign - ES6 Object.assign() ponyfill Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dominik@greysector.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rathann.fedorapeople.org/review/nodejs-object-assign/nodejs-object-a... SRPM URL: https://rathann.fedorapeople.org/review/nodejs-object-assign/nodejs-object-a... Description: ES6 Object.assign() ponyfill compatibility package.
Fedora Account System Username: rathann
The package was retired due to being orphaned for 6+ weeks.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=55734370
https://bugzilla.redhat.com/show_bug.cgi?id=1898470
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1872227
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1872227 [Bug 1872227] F34FailsToInstall: nodejs-mz
https://bugzilla.redhat.com/show_bug.cgi?id=1898470
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Package approved
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/nodejs-object-assign See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 8 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/nodejs-object-assign/review-nodejs-object- assign/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-object-assign-4.1.1-10.fc34.noarch.rpm nodejs-object-assign-4.1.1-10.fc34.src.rpm nodejs-object-assign.noarch: W: spelling-error Summary(en_US) ponyfill -> pony fill, pony-fill, ponytail nodejs-object-assign.noarch: W: spelling-error %description -l en_US ponyfill -> pony fill, pony-fill, ponytail nodejs-object-assign.noarch: W: only-non-binary-in-usr-lib nodejs-object-assign.src: W: spelling-error Summary(en_US) ponyfill -> pony fill, pony-fill, ponytail nodejs-object-assign.src: W: spelling-error %description -l en_US ponyfill -> pony fill, pony-fill, ponytail 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1898470
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |WONTFIX Flags|fedora-review+ | Last Closed| |2021-05-12 10:14:19
--- Comment #2 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- I decided not to maintain this due to lack of time. Thanks for the review, though.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com