[Bug 2151315] New: Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

Bug ID: 2151315
           Summary: Review Request: autorsync - Automate execution of
                    various rsync commands
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://jonny.fedorapeople.org/autorsync.spec
SRPM URL: https://jonny.fedorapeople.org/autorsync-1.0.5-1.fc36.src.rpm

Description:
Command to automate execution of various rsync commands based on profiles
defined on a YAML configuration file.

Fedora Account System Username: jonny

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

--- Comment #1 from Jonny Heggheim  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=95021873

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

Vitaly Zaitsev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Vitaly Zaitsev  ---
This SPEC uses legacy Python guidelines. You have to port it to a modern one:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

Older guidelines are only allowed for existing packages:
> Older guidelines are still being kept up to date, and existing packages MAY use them instead of this document

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

--- Comment #3 from Jonny Heggheim  ---
Thanks, I did not know that they were mandatory

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

--- Comment #4 from Jonny Heggheim  ---
Updated the spect+srpm to new Python packaging guidelines, same urls:

Spec URL: https://jonny.fedorapeople.org/autorsync.spec
SRPM URL: https://jonny.fedorapeople.org/autorsync-1.0.5-1.fc36.src.rpm

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

--- Comment #5 from Vitaly Zaitsev  ---
> BuildRequires: python3dist(jinja2)
> BuildRequires: python3dist(pyyaml)

No longer required. %pyproject_buildrequires will discover everything
automatically.

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

Vitaly Zaitsev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

--- Comment #6 from Jonny Heggheim  ---
(In reply to Vitaly Zaitsev from comment #5)
> > BuildRequires: python3dist(jinja2)
> > BuildRequires: python3dist(pyyaml)
>
> No longer required. %pyproject_buildrequires will discover everything
> automatically.

Without them I am getting this error, not sure if it is upstream that are using
some bad practice or if it is a bug in the rpm build system?
It might be related to comments in this issue
https://github.com/avibrazil/autorsync/issues/1

+ /usr/bin/python3 -Bs /usr/lib/rpm/redhat/pyproject_buildrequires.py
--generate-extras --python3_pkgversion 3 --wheeldir
/builddir/build/BUILD/auto_remote_sync-1.0.5/pyproject-wheeldir
Handling setuptools >= 40.8 from default build backend
Requirement satisfied: setuptools >= 40.8
   (installed: setuptools 59.6.0)
Handling wheel from default build backend
Requirement satisfied: wheel
   (installed: wheel 0.37.1)
Traceback (most recent call last):
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 501, in main
    generate_requires(
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 415, in
generate_requires
    generate_build_requirements(backend, requirements)
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 265, in
generate_build_requirements
    new_reqs = get_requires()
  File "/usr/lib/python3.10/site-packages/setuptools/build_meta.py", line 162,
in get_requires_for_build_wheel
    return self._get_build_requires(
  File "/usr/lib/python3.10/site-packages/setuptools/build_meta.py", line 143,
in _get_build_requires
    self.run_setup()
  File "/usr/lib/python3.10/site-packages/setuptools/build_meta.py", line 267,
in run_setup
    super(_BuildMetaLegacyBackend,
  File "/usr/lib/python3.10/site-packages/setuptools/build_meta.py", line 158,
in run_setup
    exec(compile(code, __file__, 'exec'), locals())
  File "setup.py", line 5, in <module>
    from autorsync import __version__
  File "/builddir/build/BUILD/auto_remote_sync-1.0.5/autorsync/__init__.py",
line 9, in <module>
    import yaml
ModuleNotFoundError: No module named 'yaml'
error: Bad exit status from /var/tmp/rpm-tmp.wHpst0 (%generate_buildrequires)
    Bad exit status from /var/tmp/rpm-tmp.wHpst0 (%generate_buildrequires)

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

--- Comment #7 from Vitaly Zaitsev  ---
> Without them I am getting this error, not sure if it is upstream that are using some bad practice or if it is a bug in the rpm build system?

Yes, upstream uses very bad Python practices.

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

--- Comment #8 from Vitaly Zaitsev  ---
> License:   LGPL

Incorrect. Use this:

License: GPL-3.0-or-later

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Link ID|                            |Github
                   |                            |avibrazil/autorsync/issues/
                   |                            |1 Github
                   |                            |avibrazil/autorsync/issues/
                   |                            |4

--- Comment #9 from Jonny Heggheim  ---
(In reply to Vitaly Zaitsev from comment #8)
> > License:   LGPL
>
> Incorrect. Use this:
>
> License: GPL-3.0-or-later

I have asked upstream to clarify their license
https://github.com/avibrazil/autorsync/issues/4

[Bug 2151315] Review Request: autorsync - Automate execution of various rsync commands

https://bugzilla.redhat.com/show_bug.cgi?id=2151315

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2024-03-06 12:48:11

--- Comment #12 from Jonny Heggheim  ---
Closing due to little feedback from upstream.