[Bug 2155775] New: Review Request: python-xword-dl - Download tool for online crossword puzzles
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
Bug ID: 2155775 Summary: Review Request: python-xword-dl - Download tool for online crossword puzzles Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/python-xword-dl/python-xword-dl.spe... SRPM URL: https://dcavalca.fedorapeople.org/review/python-xword-dl/python-xword-dl-202...
Description: xword-dl is a command-line tool to download .puz files for online crossword puzzles from supported outlets or arbitrary URLs with embedded crossword solvers. For a supported outlet, you can easily download the latest puzzle, or specify one from the archives.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=95611313
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2155776 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2155776 [Bug 2155776] Review Request: crosswords-puzzle-sets-xword-dl - Puzzle Sets from assorted newspapers for GNOME Crosswords
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |michel@michel-slm.name Assignee|nobody@fedoraproject.org |michel@michel-slm.name Status|NEW |POST
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- LGTM, APPROVED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "*No copyright* MIT License", "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2155776-crosswords- puzzle-sets-xword-dl/2155775-python-xword-dl/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-xword-dl-2022.12.14-1.fc38.noarch.rpm python-xword-dl-2022.12.14-1.fc38.src.rpm =========================================================================== rpmlint session starts ========================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp13r3zmb5')] checks: 31, packages: 2
python3-xword-dl.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/xword_dl/xword_dl.py 644 /usr/bin/env python3 python3-xword-dl.noarch: W: no-manual-page-for-binary xword-dl ============================================ 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.2 s ===========================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
python3-xword-dl.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/xword_dl/xword_dl.py 644 /usr/bin/env python3 python3-xword-dl.noarch: W: no-manual-page-for-binary xword-dl 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.1 s
Source checksums ---------------- https://files.pythonhosted.org/packages/source/x/xword_dl/xword_dl-2022.12.1... : CHECKSUM(SHA256) this package : fe42cda4a7de93279bdc65f9bd5c3efb3b151bbb2581d6f00f6be1316dd30bd9 CHECKSUM(SHA256) upstream package : fe42cda4a7de93279bdc65f9bd5c3efb3b151bbb2581d6f00f6be1316dd30bd9
Requires -------- python3-xword-dl (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.11dist(beautifulsoup4) python3.11dist(dateparser) python3.11dist(html2text) python3.11dist(lxml) python3.11dist(puzpy) python3.11dist(pyyaml) python3.11dist(requests) python3.11dist(unidecode) python3.11dist(xmltodict)
Provides -------- python3-xword-dl: python-xword-dl python3-xword-dl python3.11-xword-dl python3.11dist(xword-dl) python3dist(xword-dl)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2155775 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Haskell, SugarActivity, PHP, fonts, Perl, R, Ocaml, C/C++, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #3 from Kevin Fenzi kevin@scrye.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-xword-dl
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9123753895 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9123753895
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-12-24 07:03:22
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9123753895 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b2f57b8d54 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b2f57b8d54
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b312e27a4c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b312e27a4c
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b2f57b8d54 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b2f57b8d54 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b2f57b8d54
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b312e27a4c has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b312e27a4c *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b312e27a4c
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b2f57b8d54 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2155775
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-b312e27a4c has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com