[Bug 670090] New: Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: bicon - Bidirectional Console

https://bugzilla.redhat.com/show_bug.cgi?id=670090

Summary: Review Request: bicon - Bidirectional Console
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://fujiwara.fedorapeople.org/bicon/bicon.spec
SRPM URL: http://fujiwara.fedorapeople.org/bicon/bicon-0.2.0-1.src.rpm
Description:
BiCon is the bidirectional console as presented by Arabeyes.

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #1 from fujiwara  2011-01-17 02:28:59 EST ---
Forgot dist tag in NVR:
SRPM URL: http://fujiwara.fedorapeople.org/bicon/bicon-0.2.0-1.fc15.src.rpm

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #2 from fujiwara  2011-01-17 02:35:36 EST ---
Scratch build is done:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2725386

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

Daiki Ueno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #3 from Daiki Ueno  2011-01-17 03:59:28 EST ---
I'm trying to review.

- rpmlint reports several errors and warnings with binary RPMs

bicon.x86_64: E: standard-dir-owned-by-package /usr/share/man
 bicon.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1

Please exclude those directories from %files.

bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/README 0600L
 bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/COPYING 0600L
 bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/AUTHORS 0600L

Please give proper permissions to %docs.

bicon.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/bicon/libbjoining.so
 bicon.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/bicon/libbconsole.so

Please exclude those symlinks from the base package.

- it would be nice to preserve timestamps when install.
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

Consider using something like:

make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install

- you can drop BuildRoot stuff
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

- consider having a separate package for fonts
https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_...

I think this might not apply since the package contains only 4 fonts and each
of them is about 4KB, but if you plan to subpackage them, you could check
terminus-fonts-console.

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #4 from fujiwara  2011-01-17 21:39:31 EST ---
(In reply to comment #3)
> I'm trying to review.

Thanks. I updated spec file:
Spec URL: http://fujiwara.fedorapeople.org/bicon/bicon.spec
SRPM URL: http://fujiwara.fedorapeople.org/bicon/bicon-0.2.0-2.fc15.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2727535
> bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/README 0600L
>  bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/COPYING 0600L
>  bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/AUTHORS 0600L

I didn't get the same error with my scratch build but I added chmod at the
moment.
> consider having a separate package for fonts
>
> https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_...
>
> I think this might not apply since the package contains only 4 fonts and each
> of them is about 4KB, but if you plan to subpackage them, you could check
> terminus-fonts-console.

OK, I think probably sub-packages are good because fonts and keymaps are not
used in TERM=xterm.

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

Daiki Ueno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #5 from Daiki Ueno  2011-01-18 02:03:48 EST ---
(In reply to comment #4)
> > bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/README 0600L
> >  bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/COPYING 0600L
> >  bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/AUTHORS 0600L
>
> I didn't get the same error with my scratch build but I added chmod at the
> moment.

Sorry, my bad.  That was because I used "fakeroot rpmbuild --rebuild" to check
the SRPM on F-14.  Please feel free to revert the change when you import the
package into the git.

BTW, according to COPYING, bicon/pty_spawn.c is covered by the Python license. 
The License tag should be fixed:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licens...

APPROVED.

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |ct.org
               Flag|                            |fedora-cvs?

--- Comment #6 from fujiwara  2011-01-18 05:27:44 EST ---
New Package SCM Request
=======================
Package Name: bicon
Short Description: Bidirectional Console
Owners: fujiwara
Branches: F-13, F-14
InitialCC: i18n-team

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2728197

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #7 from Jason Tibbitts  2011-01-18 09:03:13 EST ---
Git done (by process-git-requests).

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #8 from fujiwara  2011-01-19 22:22:40 EST ---
http://koji.fedoraproject.org/koji/buildinfo?buildID=214933

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #9 from Fedora Update System  2011-01-19 22:49:53 EST ---
bicon-0.2.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/bicon-0.2.0-1.fc14

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #10 from Fedora Update System  2011-01-19 22:50:00 EST ---
bicon-0.2.0-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/bicon-0.2.0-1.fc13

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #11 from Fedora Update System  2011-01-20 14:54:03 EST ---
bicon-0.2.0-1.fc14 has been pushed to the Fedora 14 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update bicon'.  You can provide
feedback for this update here:
https://admin.fedoraproject.org/updates/bicon-0.2.0-1.fc14

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #12 from Fedora Update System  2011-01-25 15:55:05 EST ---
bicon-0.2.0-1.fc14 has been pushed to the Fedora 14 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |bicon-0.2.0-1.fc14
         Resolution|                            |ERRATA
        Last Closed|                            |2011-01-25 15:55:10

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

--- Comment #13 from Fedora Update System  2011-01-25 15:56:42 EST ---
bicon-0.2.0-1.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 670090] Review Request: bicon - Bidirectional Console

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=670090

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|bicon-0.2.0-1.fc14          |bicon-0.2.0-1.fc13