[Bug 1944554] New: Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Bug ID: 1944554
           Summary: Review Request: perl-Glib-IO - Perl binding to the GIO
                    library
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://skim.cz/tmp/perl-Glib-IO.spec

SRPM URL: https://skim.cz/tmp/perl-Glib-IO-0.001-1.fc35.src.rpm

Description: The Glib::IO module allows a Perl developer to access the GIO
library, the high level I/O and platform library of the GNOME development
platform.

Fedora Account System Username: mspacek

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=64834907

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Michal Josef Spacek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

--- Comment #1 from Michal Josef Spacek  ---
BTW: This package is my first package in Fedora :-)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Glib-IO-0.001-1.fc35.noarch.rpm | sort | uniq -c |
grep -v rpmlib
      1 perl(Glib::Object::Introspection) >= 0.014
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Glib-IO-0.001-1.fc35.noarch.rpm | sort | uniq -c
      1 perl(Glib::IO) = 0.001
      1 perl-Glib-IO = 0.001-1.fc35
Binary provides are Ok.

$ rpmlint ./perl-Glib-IO*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
I am not a sponsor of packagers. 
However for me, the package can be approved.

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Petr Pisar  ---
I cannot see where Glib module is used in the tests (grep -Hnr 'Glib[^:]' ./t).
Do we really need perl(Glib) among BuildRequires?

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

--- Comment #4 from Michal Josef Spacek  ---
(In reply to Petr Pisar from comment #3)
> I cannot see where Glib module is used in the tests (grep -Hnr 'Glib[^:]'
> ./t). Do we really need perl(Glib) among BuildRequires?

There is usage of Glib::MainLoop in t/file-enumerator.t

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

--- Comment #5 from Petr Pisar  ---
The usage is this one:

my $loop = Glib::MainLoop->new ();

That does not load Glib module. The test just expects that Glib::MainLoop was
imported
implicitly somewhere somehow (probably by Glib transitively loaded by "use
Glib::IO;"
at line #5). It's maybe a deficiency in the test, but the RPM dependency should
not be there:

[test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'Glib::MainLoop->new'
Can't locate object method "new" via package "Glib::MainLoop" (perhaps you
forgot to load "Glib::MainLoop"?) at -e line 1.
[test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'use Glib::MainLoop;
Glib::MainLoop->new'
Can't locate Glib/MainLoop.pm in @INC (you may need to install the
Glib::MainLoop module) (@INC contains: lib /usr/local/lib64/perl5/5.32
/usr/local/share/perl5/5.32 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at -e line 1.
BEGIN failed--compilation aborted at -e line 1.
[test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'use Glib; Glib::MainLoop->new'
[test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'use Glib::IO;
Glib::MainLoop->new'
[test@fedora-35 Glib-IO-0.001]$

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

--- Comment #6 from Michal Josef Spacek  ---
(In reply to Petr Pisar from comment #5)
> The usage is this one:
>
> my $loop = Glib::MainLoop->new ();
>
> That does not load Glib module. The test just expects that Glib::MainLoop
> was imported
> implicitly somewhere somehow (probably by Glib transitively loaded by "use
> Glib::IO;"
> at line #5). It's maybe a deficiency in the test, but the RPM dependency
> should not be there:

Yes, you are right.
I removed this dependency.

https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO.spec
https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO-0.001-1.fc35.src.rpm

Thanks.

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #7 from Jitka Plesnikova  ---
(In reply to Michal Josef Spacek from comment #6)
> (In reply to Petr Pisar from comment #5)
> > The usage is this one:
> >
> > my $loop = Glib::MainLoop->new ();
> >
> > That does not load Glib module. The test just expects that Glib::MainLoop
> > was imported
> > implicitly somewhere somehow (probably by Glib transitively loaded by "use
> > Glib::IO;"
> > at line #5). It's maybe a deficiency in the test, but the RPM dependency
> > should not be there:
>
> Yes, you are right.
> I removed this dependency.
>
> https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO.spec
> https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO-0.001-1.fc35.src.rpm
>
> Thanks.

# Tests:
-BuildRequires:  perl(Glib)
 BuildRequires:  perl(Test::More)

Package looks good now.

Resolution:
Approved

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

--- Comment #8 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Glib-IO

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

--- Comment #9 from Michal Josef Spacek  ---
Thank you for review and repository.

[Bug 1944554] Review Request: perl-Glib-IO - Perl binding to the GIO library

https://bugzilla.redhat.com/show_bug.cgi?id=1944554

Michal Josef Spacek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |perl-Glib-IO-0.001-1.fc35
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-05-05 17:49:48