[Bug 191304] New: Review Request: crossfire-client - Client programs for the crossfire game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
Summary: Review Request: crossfire-client - Client programs for the crossfire game Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: wart@kobold.org QAContact: fedora-package-review@redhat.com
Spec URL: http://www.kobold.org/~wart/fedora/crossfire-client.spec SRPM URL: http://www.kobold.org/~wart/fedora/crossfire-client-1.9.0-2.src.rpm Description:
Client for playing the new client/server based version of Crossfire. This package allows you to connect to crossfire servers around the world. You do not need install the crossfire server in order to use this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |191305
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |chris.stone@gmail.com OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
Bug 191304 depends on bug 191305, which changed state.
Bug 191305 Summary: Review Request: crossfire-client-images - Images for the crossfire client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191305
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |WONTFIX Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From chris.stone@gmail.com 2006-05-15 22:43 EST ------- * rpmlint output clean * Package named according to Package Naming Guidelines * Spec file matches base package %{name} * Package meets packaging guidelines * License is open source compatible * License matches actual license * License file contained in %doc * Spec file in American English * Spec file is legible * Source file matches upstream 62a9ac007700d1d811fa097fe6790f7a crossfire-client-1.9.0.tar.gz 62a9ac007700d1d811fa097fe6790f7a crossfire-client-1.9.0.tar.gz * Package successfully builds for FC5 x86_64 * All build dependencies listed in Build Requires * Package does not contain locales * Package does not contain any shared libraries * Package is not relocatable * Package owns the directories it creates * No duplicate files in %files * %files contains acceptable %defattr settings * Package contains acceptable %clean section * Macro use is consistant * Package contains permissible code * No large amounts of documentation for a -doc package * Files in %doc do not affect run time of application * No header files or static libraries. or .pc files present * No .so files present * No devel package built * No .la files present * Package include .desktop file - Should probably use %{name}.desktop * Package does not own files or directories owned by other packages
*** APPROVED ***
Non-Blocking SHOULDS: - Contact upstream about sound problem (I'm assuming you already have done this) - Contact upstream about -images package (Noted that you have done this) - Build -sounds package when sound is working (Probably already on your TODO list)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
------- Additional Comments From wart@kobold.org 2006-05-15 22:47 EST ------- (In reply to comment #1)
Non-Blocking SHOULDS:
- Contact upstream about sound problem (I'm assuming you already have done this)
- Contact upstream about -images package (Noted that you have done this)
- Build -sounds package when sound is working (Probably already on your TODO list)
I had originally left sound support in, but upstream told me that it's broken on 2.6 kernels, so I turned it off. It sounds like they plan to use SDL for sound at some unspecified time in the future. I definitely plan on adding support for sound once it works again.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
------- Additional Comments From wart@kobold.org 2006-05-17 00:11 EST ------- Imported and built. Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191304
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: crossfire-client - Client programs for the crossfire game
https://bugzilla.redhat.com/show_bug.cgi?id=191304
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla