[Bug 2380941] New: Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

Bug ID: 2380941
           Summary: Review Request: rust-sev4 - Library for AMD SEV -
                    version 4
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fed...
Description: Library for AMD SEV.
Fedora Account System Username: uril

Currently available in Fedora rust-sev version 6, but some packages depends on
rust-sev version 4.

Spec file was created with:
fedpkg clone -a rust-sev
cd rust-sev
git checkout -b sev4 078c510ed92f03969cf36d56f88fb4797a143c0e
# 078c510ed92f03969cf36d56f88fb4797a143c0e is the last commit before version 6
vim rust-sev.spec # changing Name from rust-sev to rust-sev4
mv rust-sev.spec rust-sev4.spec

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

Sergio Lopez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(tfanelli@redhat.c
                   |                            |om)

--- Comment #1 from Sergio Lopez  ---
@uril Which Fedora packages depend on sev4?

@tfanelli PTAL.

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

Tyler Fanelli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(tfanelli@redhat.c |
                   |om)                         |

--- Comment #2 from Tyler Fanelli  ---
Are you using the launch API in this version? Version 4 of this library doesn't
set the memory region attributes to private, which may cause issues with
guest_memfd on newer kernels. If you're not using that, then introducing this
is fine with me.

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #3 from Fabio Valentini  ---
I don't know what happened here, but the crate downloaded from crates.io
doesn't match the tarball you used in this package. Both the sha256sum of the
.crate file and checksums of individual files don't match.

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

--- Comment #4 from Uri Lublin  ---
(In reply to Sergio Lopez from comment #1)
> @uril Which Fedora packages depend on sev4?
>
> @tfanelli PTAL.

az-cvm-vtpm - bug 2370932
az-snp-vtpm - bug 2370933
trustee-guest-components depends on these

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

--- Comment #5 from Uri Lublin  ---
(In reply to Fabio Valentini from comment #3)
> I don't know what happened here, but the crate downloaded from crates.io
> doesn't match the tarball you used in this package. Both the sha256sum of
> the .crate file and checksums of individual files don't match.

I changed nothing but the name, such that rust-sev4 is the same as
rust-sev (version 4.0.0), as it was already tested and used.

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

--- Comment #6 from Fabio Valentini  ---
The question isn't the origin of the *.spec file, the question is the origin of
the *.crate file.

It doesn't match the one downloaded from crates.io, which is quite suspicious.

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

--- Comment #7 from Uri Lublin  ---
Yes, I understand your concern is the crate file. My comment 5 still holds.

I'll prepare an SRPM with the original crate.

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

--- Comment #8 from Uri Lublin  ---
(In reply to Uri Lublin from comment #7)
> I'll prepare an SRPM with the original crate.

I'll first try building rust-az-???-vtpm v0.7.3 (related: bug 2370932 comment
11)

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

--- Comment #9 from Fabio Valentini  ---
Do you still need this package for v4?

[Bug 2380941] Review Request: rust-sev4 - Library for AMD SEV - version 4

https://bugzilla.redhat.com/show_bug.cgi?id=2380941

Uri Lublin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2025-09-04 14:40:41

--- Comment #10 from Uri Lublin  ---
No, we modified the code to use sev-v6.
Closing it as won'tfix.