[Bug 1426987] New: Review Request: golang-github-bep-gitmap - A fast way to create a map from all the filenames to info objects for a given revision of a Git repo.
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
Bug ID: 1426987 Summary: Review Request: golang-github-bep-gitmap - A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fred@fredericolima.com.br QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 1426972
Spec URL: https://fredlima.fedorapeople.org/packaging/golang-github-bep-gitmap.spec SRPM URL: https://fredlima.fedorapeople.org/packaging/golang-github-bep-gitmap-0-0.1.g...
Description: A fast way to create a map from all the filenames to info objects for a given revision of a Git repo.
Fedora Account System Username: fredlima
skipped check and unit testing because the tests are made with historical commits, and doesn't work on upstream with any new commit.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1426972 [Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |athoscribeiro@gmail.com Assignee|nobody@fedoraproject.org |athoscribeiro@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Athos Ribeiro athoscribeiro@gmail.com --- Hi Fred,
There are a few problems with rpmlint, can you fix these issues?
Just make your Summary shorter and make sure it does not end with a period (also, see that the description should end with a period. You want to check that because you are using your summary as the description).
golang-github-bep-gitmap-devel.noarch: W: summary-ended-with-dot C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo.
golang-github-bep-gitmap-devel.noarch: E: summary-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo.
golang-github-bep-gitmap-devel.noarch: E: description-line-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo.
golang-github-bep-gitmap-devel.noarch: W: spelling-error Summary(en_US) filenames -> file names, file-names, filaments
Other than this, the package looks good. I will trust that you will fix those before uploading. So, I am approving the package now.
======================= =======================
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-bep-gitmap-devel-0-0.1.gitdcb907b.fc26.noarch.rpm golang-github-bep-gitmap-0-0.1.gitdcb907b.fc26.src.rpm golang-github-bep-gitmap-devel.noarch: W: spelling-error Summary(en_US) filenames -> file names, file-names, filaments golang-github-bep-gitmap-devel.noarch: W: spelling-error Summary(en_US) repo -> rope, rep, reps golang-github-bep-gitmap-devel.noarch: W: summary-ended-with-dot C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. golang-github-bep-gitmap-devel.noarch: E: summary-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. golang-github-bep-gitmap-devel.noarch: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments golang-github-bep-gitmap-devel.noarch: W: spelling-error %description -l en_US repo -> rope, rep, reps golang-github-bep-gitmap-devel.noarch: E: description-line-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. golang-github-bep-gitmap.src: W: spelling-error Summary(en_US) filenames -> file names, file-names, filaments golang-github-bep-gitmap.src: W: spelling-error Summary(en_US) repo -> rope, rep, reps golang-github-bep-gitmap.src: W: summary-ended-with-dot C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. golang-github-bep-gitmap.src: E: summary-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. golang-github-bep-gitmap.src: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments golang-github-bep-gitmap.src: W: spelling-error %description -l en_US repo -> rope, rep, reps golang-github-bep-gitmap.src: E: description-line-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. 2 packages and 0 specfiles checked; 4 errors, 10 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory golang-github-bep-gitmap-devel.noarch: W: spelling-error Summary(en_US) filenames -> file names, file-names, filaments golang-github-bep-gitmap-devel.noarch: W: spelling-error Summary(en_US) repo -> rope, rep, reps golang-github-bep-gitmap-devel.noarch: W: summary-ended-with-dot C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. golang-github-bep-gitmap-devel.noarch: E: summary-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. golang-github-bep-gitmap-devel.noarch: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments golang-github-bep-gitmap-devel.noarch: W: spelling-error %description -l en_US repo -> rope, rep, reps golang-github-bep-gitmap-devel.noarch: E: description-line-too-long C A fast way to create a map from all the filenames to info objects for a given revision of a Git repo. 1 packages and 0 specfiles checked; 2 errors, 5 warnings.
Requires -------- golang-github-bep-gitmap-devel (rpmlib, GLIBC filtered):
Provides -------- golang-github-bep-gitmap-devel: golang(github.com/bep/gitmap) golang-github-bep-gitmap-devel
Source checksums ---------------- https://github.com/bep/gitmap/archive/dcb907b39a0690430d435eb8f63cd881196123... : CHECKSUM(SHA256) this package : 7be1942795299c9e5331514a093b12e8110d5aac6f90cf84465932956716cc2a CHECKSUM(SHA256) upstream package : 7be1942795299c9e5331514a093b12e8110d5aac6f90cf84465932956716cc2a
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
--- Comment #2 from Frederico Lima fred@fredericolima.com.br --- updated, can you check again Athos? Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
--- Comment #3 from Athos Ribeiro athoscribeiro@gmail.com --- It looks good now :)
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
Frederico Lima fred@fredericolima.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |golang-github-bep-gitmap - |golang-github-bep-gitmap - |A fast way to create a map |Create map from filename to |from all the filenames to |info object from revision |info objects for a given |of a repo |revision of a Git repo. |
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-bep-gitmap
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- golang-github-bep-gitmap-0-0.1.gitdcb907b.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-eeef8a4567
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-bep-gitmap-0-0.1.gitdcb907b.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-eeef8a4567
https://bugzilla.redhat.com/show_bug.cgi?id=1426987
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-06-09 14:51:15
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-bep-gitmap-0-0.1.gitdcb907b.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com