Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250904
Summary: Review Request: fuse-python - Python bindings for FUSE Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lemenkov@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://peter.fedorapeople.org/fuse-python.spec SRPM URL: http://peter.fedorapeople.org/fuse-python-0.2-1.fc7.src.rpm
Description: This package provides python bindings for FUSE. FUSE makes it possible to implement a filesystem in a userspace program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250904
------- Additional Comments From lemenkov@gmail.com 2007-08-05 05:11 EST ------- BTW what correct naming should be for this package - fuse-python (as in upstream) or python-fuse?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
ondrejj@salstar.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ondrejj@salstar.sk
------- Additional Comments From ondrejj@salstar.sk 2007-09-06 04:30 EST ------- rpmlint says: W: fuse-python invalid-license GPL W: fuse-python mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 6)
Please change license to GPLv2 or GPLv2+ . Do not mix tabs and spaces in spec file.
I think python-fuse name is better, but fuse-python is not bad too.
%{python_sitearch}/fuseparts directory is not owned by packages. Please add an %dir %{python_sitearch}/fuseparts into spec file.
Add these files to documentation: examples + it's content README.1st maybe README.historic too and maybe PKG-INFO too, which contains many interesting information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From ondrejj@salstar.sk 2007-09-06 06:40 EST ------- There are more rpmlint errors on binary packages. They have been fixed in my new packages:
* Thu Sep 6 2007 Jan ONDREJ (SAL) ondrejj@salstar.sk 0.2-2 - changed permissions for sitearch files to 644 - added fuseparts dir to package - added egg-info directory with it's content - license changed to LGPLv2, according to documentation and sources - added provides for python-fuse (remove it on rename)
http://www.salstar.sk/pub/fedora/SPECS/fuse-python.spec http://www.salstar.sk/pub/fedora/SRPMS/7/fuse-python-0.2-2.fc7.src.rpm
May be it needs to be renamed to python-fuse, but I don't know it it needs a new Review Request ticket or not.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name
------- Additional Comments From opensource@till.name 2007-09-06 08:37 EST ------- You do not use the python_sitelib and pyver macros, therefore you should not define them.
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} %{!?pyver: %define pyver %(%{__python} -c "import sys ; print sys.version[:3]")}
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From ondrejj@salstar.sk 2007-09-09 10:56 EST ------- Done.
* Sun Sep 9 2007 Jan ONDREJ (SAL) ondrejj@salstar.sk 0.2-3 - removed non used macros - Changelog file converted to UTF-8
http://www.salstar.sk/pub/fedora/SPECS/fuse-python.spec http://www.salstar.sk/pub/fedora/SRPMS/7/fuse-python-0.2-3.fc7.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From adam@spicenitz.org 2007-10-04 22:32 EST ------- Hi,
Can you follow the install procedure given here: http://fedoraproject.org/wiki/Packaging/Python/Eggs#head-3e899702195642d7d12...
This will allow the egg information to work in Fedora 8 and beyond.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From lemenkov@gmail.com 2007-10-05 02:06 EST ------- Done.
http://peter.fedorapeople.org/fuse-python.spec http://peter.fedorapeople.org/fuse-python-0.2-4.fc7.src.rpm
I've got some things to discuss:
* I changed %files section according to the Packaging/Python/Eggs from Jan's variant when all files to package were explicitly named to more simplified form %{python_sitearch}/* - which variant is preferrable? Personally I like Jan's idea about explicit naming of all files but in the above example they use short version: %{python_sitearch}/*
* What macro should be used? python_sitearch or python_sitelib? What are differences between these macros and which is prefferable?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From ondrejj@salstar.sk 2007-10-05 02:20 EST ------- OK, shortest form is OK.
python_sitearch macro is for architecture dependent files. Your package contains an *.so module for python, which is architecture dependent, this means, that it is correctly packaged into python_sitearch.
Please use %{__python} macro.
BuildRequires: python-devel can be dropped, because it is required by setuptools. Tested build on fedora-devel and fedora7.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From lemenkov@gmail.com 2007-10-05 02:39 EST ------- Ok, cleaned a bit. About macros - I decided not to use them at all.
http://peter.fedorapeople.org/fuse-python.spec http://peter.fedorapeople.org/fuse-python-0.2-5.fc7.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
ondrejj@salstar.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
------- Additional Comments From ondrejj@salstar.sk 2007-10-09 02:01 EST ------- OK, package APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From lemenkov@gmail.com 2007-10-09 04:20 EST ------- New Package CVS Request ======================= Package Name: fuse-python Short Description: Python bindings for FUSE - filesystem in userspace Owners: peter Branches: FC-6 F-7 Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-10-09 11:46 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From updates@fedoraproject.org 2007-10-11 18:55 EST ------- fuse-python-0.2-5.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update fuse-python'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
------- Additional Comments From updates@fedoraproject.org 2007-10-12 16:06 EST ------- fuse-python-0.2-5.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: fuse-python - Python bindings for FUSE
https://bugzilla.redhat.com/show_bug.cgi?id=250904
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |ERRATA Fixed In Version| |0.2-5.fc7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=250904
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #15 from Peter Lemenkov lemenkov@gmail.com 2009-10-05 10:45:11 EDT --- Package Change Request ====================== Package Name: fuse-python New Branches: EL-5 Owners: peter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=250904
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #16 from Kevin Fenzi kevin@tummy.com 2009-10-06 13:46:10 EDT --- cvs done.
package-review@lists.fedoraproject.org