https://bugzilla.redhat.com/show_bug.cgi?id=1649583
Bug ID: 1649583 Summary: Review Request: golang-github-tv42-httpunix - Go library to talk HTTP over Unix domain sockets Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://eclipseo.fedorapeople.org/golang-github-tv42-httpunix.spec SRPM URL: https://eclipseo.fedorapeople.org/golang-github-tv42-httpunix-0-0.1.20181113...
Koji scrtch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30871479
Description: Go library to talk HTTP over Unix domain sockets.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=1649583
Carl George carl@george.computer changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carl@george.computer Assignee|nobody@fedoraproject.org |carl@george.computer Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1649583
Carl George carl@george.computer changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags|fedora-review? |fedora-review+
--- Comment #1 from Carl George carl@george.computer --- This makes fedora-review happy, and I've checked each of the manual review items. Looks good to me.
Just a suggestion, not a blocker, but since common_description is just the Summary with a period, you could remove common_description entirely and just use `%{summary}.` in it's place to avoid unnecessary duplication.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1649583
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Thanks Carl!
https://bugzilla.redhat.com/show_bug.cgi?id=1649583
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-tv42-httpunix
package-review@lists.fedoraproject.org