https://bugzilla.redhat.com/show_bug.cgi?id=2365763
Bug ID: 2365763 Summary: Review Request: lf - Terminal file manager Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: me@pennbauman.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/pennbauman/ports/srpm-bui... SRPM URL: https://download.copr.fedorainfracloud.org/results/pennbauman/ports/srpm-bui... Description: Terminal file manager. Fedora Account System Username: pennbauman
This depends on golang-github-xuanwo-locale.
COPR: https://copr.fedorainfracloud.org/coprs/pennbauman/ports/package/lf SCM: https://codeberg.org/pennbauman/lf.rpm
This will be my first Fedora package, so I require sponsorship. I have been packaging this tool for years on Copr, and in future I would like to introduce other software I package on Copr to Fedora. Please, let me know if you are interested in sponsoring me.
https://bugzilla.redhat.com/show_bug.cgi?id=2365763
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9025547 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2365763
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2365761 CC| |solomoncyj@gmail.com
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2365761 [Bug 2365761] Review Request: golang-github-xuanwo-locale - Cross platform locale detection for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=2365763
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Assignee|nobody@fedoraproject.org |mikel@olasagasti.info Status|NEW |ASSIGNED
--- Comment #2 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
%global common_description %{expand: Terminal file manager.}
Description should be a bit more... descriptive.
%generate_buildrequires %go_generate_buildrequires
Go-SIG will propose to make vendored builds the default option using go-vendor-tools for Fedora 43. lf's dependency stack is small, but I would recommend to adopt the new format to make things simpler for you. You can generate the new spec with `go2rpm -p vendor github.com/gokcehan/lf` and you can check examples like helm or opentofu packages to see how it works.
I would recommend to join Go-SIG's Matrix channel for more guidance if required: https://matrix.to/#/#golang:fedoraproject.org
If you prefer to keep the old method I can review the dependency as well.
install -m 0644 -Dvp etc/%{name}.zsh %{buildroot}%{_datadir}/zsh/site-functions/_%{name} install -m 0644 -Dvp etc/%{name}.fish %{buildroot}%{_datadir}/fish/vendor_completions.d/%{name}.fish
You can use %{fish_completions_dir}/%{name}.fish and %{zsh_completions_dir}/_%{name} as you do with %{bash_completions_dir}
https://bugzilla.redhat.com/show_bug.cgi?id=2365763
--- Comment #3 from me@pennbauman.com me@pennbauman.com --- I've updated the description and the macro usage. I've got vendoring working locally, but I don't think I can have it work on Copr without uploading the lf-r35-vendor.tar.bz2 file to the lookaside cache. If you want to upload that (and the regular regular source tarball) to the cache, I could setup vendoring and also add a sources file.
Updated src.rpm and spec SRPM URL: https://download.copr.fedorainfracloud.org/results/pennbauman/ports/srpm-bui... Spec URL: https://download.copr.fedorainfracloud.org/results/pennbauman/ports/srpm-bui...
https://bugzilla.redhat.com/show_bug.cgi?id=2365763
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2090045 --> https://bugzilla.redhat.com/attachment.cgi?id=2090045&action=edit The .spec file difference from Copr build 9025547 to 9052994
https://bugzilla.redhat.com/show_bug.cgi?id=2365763
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9052994 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com