https://bugzilla.redhat.com/show_bug.cgi?id=1951479
Bug ID: 1951479 Summary: Review Request: perl-CLI-Osprey - MooX::Options + MooX::Cmd + Sanity Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: emmanuel@seyman.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0.... SRPM URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0.... Description: CLI::Osprey is a module to assist in writing command-line applications with M* OO modules (Moose, Moo, Mo). With it, you structure your app as one or more modules, which get instantiated with the command-line arguments as attributes. Arguments are parsed using Getopt::Long::Descriptive, and both long and short help messages as well as complete manual pages are automatically generated. An app can be a single command with options, or have sub-commands (like git). Sub-commands can be defined as modules (with options of their own) or as simple code-refs.
Fedora Account System Username: eseyman Rpmlint Output: perl-CLI-Osprey.src: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon perl-CLI-Osprey.src: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1950798 Depends On| |1951040 Doc Type|--- |If docs needed, set a value Whiteboard| |NotReady
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1950798 [Bug 1950798] perl-Dancer2-0.301002 is available https://bugzilla.redhat.com/show_bug.cgi?id=1951040 [Bug 1951040] Review Request: perl-Test-Lib - Use libraries from a t/lib directory
https://bugzilla.redhat.com/show_bug.cgi?id=1951479 Bug 1951479 depends on bug 1951040, which changed state.
Bug 1951040 Summary: Review Request: perl-Test-Lib - Use libraries from a t/lib directory https://bugzilla.redhat.com/show_bug.cgi?id=1951040
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jplesnik@redhat.com Flags| |needinfo?(emmanuel@seyman.f | |r)
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Please add valid link for spec file.
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(emmanuel@seyman.f |needinfo+ |r) |
--- Comment #2 from Emmanuel Seyman emmanuel@seyman.fr --- Spec URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey.sp... SRPM URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0....
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed
BuildRequires FIX: Please add build-require perl(lib) - t/load-on-use.t:5 TODO: Add version constrain to 'perl(Module::Build::Tiny) >= 0.034'
$ rpm -qp --requires perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(CLI::Osprey::Descriptive) 1 perl(CLI::Osprey::Descriptive::Usage) 1 perl(CLI::Osprey::InlineSubcommand) 1 perl(Getopt::Long::Descriptive) >= 0.100 1 perl(Getopt::Long::Descriptive::Usage) 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Moo::Role) 1 perl(overload) 1 perl(Path::Tiny) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) Binary requires are almost Ok. FIX: Please add run-require perl(Pod::Usage) - lib/CLI/Osprey/Role.pm:321
$ rpm -qp --provides perl-CLI-Osprey-0.08-1.fc35.noarch.rpm | sort | uniq -c 1 perl(CLI::Osprey) = 0.08 1 perl-CLI-Osprey = 0.08-1.fc35 1 perl(CLI::Osprey::Descriptive) = 0.08 1 perl(CLI::Osprey::Descriptive::Usage) = 0.08 1 perl(CLI::Osprey::InlineSubcommand) = 0.08 1 perl(CLI::Osprey::Role) = 0.08 Binary provides are Ok.
$ rpmlint ./perl-CLI-Osprey* perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon perl-CLI-Osprey.noarch: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr perl-CLI-Osprey.src: W: spelling-error Summary(en_US) MooX -> Mo Ox, Moo X, Moon perl-CLI-Osprey.src: W: spelling-error Summary(en_US) Cmd -> Cm, Cd, Cmdr 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items and consider fixing 'TODO' item.
Resolution: Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
--- Comment #4 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Jitka Plesnikova from comment #3)
FIX: Please add build-require perl(lib) - t/load-on-use.t:5
Fixed.
TODO: Add version constrain to 'perl(Module::Build::Tiny) >= 0.034'
Fixed.
FIX: Please add run-require perl(Pod::Usage) - lib/CLI/Osprey/Role.pm:321
Fixed.
Spec URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey.sp... SRPM URL: https://people.parinux.org/~seyman/fedora/perl-CLI-Osprey/perl-CLI-Osprey-0....
Resolution: Approved
Thank you, Jikta. I've requested the repository: https://pagure.io/releng/fedora-scm-requests/issue/33797
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CLI-Osprey
https://bugzilla.redhat.com/show_bug.cgi?id=1951479
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-CLI-Osprey-0.08-1.fc35 Resolution|--- |RAWHIDE Last Closed| |2021-06-04 08:34:56
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com