[Bug 1411961] New: Review Request: golang-github-milochristiansen-axis2 - A simple virtual filesystem API
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
Bug ID: 1411961 Summary: Review Request: golang-github-milochristiansen-axis2 - A simple virtual filesystem API Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rosser.bjr@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-a... SRPM URL: https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-a...
Description: AXIS is based on a few simple interfaces and a set of API functions that operate on these interfaces. Clients use the provided implementations of these interfaces (or provide their own custom implementations) to create "data sources" that may be mounted on a "file system" and used for OS-independent file IO.
AXIS was originally written to allow files inside of archives to be handled with exactly the same API as used for files inside of directories, but it has since grown to allow "logical" files and directories as well as "multiplexing" multiple items on the same location (to, for example, make two directories look and act like one). These properties make AXIS perfect for handling data and configuration files for any program where flexibility is important, the program does not need to know where its files are actually located, it simply needs them to be at a certain place in it's AXIS file system. Changing where a program loads it's files from is then as simple as changing the code that initializes the file system.
Fedora Account System Username: tc01
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Initial comments:
1) You should use Release: 0.1.git%{shortcommit}%{?dist} (including the leading zero), since this is a pre-release snapshot, not a post-release-snapshot.
2) The zlib license has only been confirmed for another repo, but not for this one. Please make sure that the same license applies for this code too.
3) You might want to use a different target file name four your download, for example: "Source0: https://%%7Bprovider_prefix%7D/archive/%%7Bcommit%7D/%%7Bproject%7D-%%7Brepo..." (so _including_ the "project" prefix; no other changes in the .spec file needed), to prevent confusion / conflicts with other package's sources.
4) You can remove the empty %if-%endif blocks at lines 70 and 89.
5) Please remove / adapt the GOPATH definition on line 144, the Godeps directory isn't present in the sources - is this a leftover from an earler version?
6) Please ask upstream to include a COPYING file in this repository too (and link the upstream issue in the .spec file or in a comment here, to document that you did your "homework".
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Pinging submitter.
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #4 from Ben Rosser rosser.bjr@gmail.com --- Spec URL: https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-a... SRPM URL: https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-a...
- Clean up template golang spec file, removing Godeps path and an empty ifdef block. - Renamed download of Source0 to include the project prefix. - Change versioning to pre-release snapshot versions. - Include link to upstream bug requesting a license/copying file. - Added comment asking upstream to add license file.
- The zlib license has only been confirmed for another repo, but not for this one. Please make sure that the same license applies for this code too.
It does; both this code and golang-github-milochristiansen-lua are components of Rubble (http://dffd.bay12games.com/file.php?id=11368). The License file included in that archive has the following text: https://paste.fedoraproject.org/paste/4IDKJAQ4pxQnr13Wsubzk15M1UNdIGYhyRLivL... which confirms that both axis2 and lua are both zlib licensed.
Furthermore, the source files all contain zlib license headers.
I have filed another ticket against the axis2 repository asking for a license file to be included in that repository though. (I was hoping that upstream would add one to both after I filed the other ticket against the lua repository): https://github.com/milochristiansen/axis2/issues/1
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Package looks good now, except for two non-blocking "issues":
1) You missed an empty %if-endif block at line 86. 2) It would be nice if the %description was wrapped at 72 characters (I don't exactly know why, but it seems to be common practice).
You can just fix the %description line lengths before importing into git.
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-milochristi...
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe6485afd2
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8831b42f1
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bab763fd2d
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1621f70b10
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe6485afd2
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1621f70b10
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bab763fd2d
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8831b42f1
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-04-14 13:19:38
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1411961
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- golang-github-milochristiansen-axis2-0-0.3.git20ad745.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla