[Bug 1487632] New: Review Request: perl-Acme-Alien-DontPanic - Test module for Alien::Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487632
Bug ID: 1487632 Summary: Review Request: perl-Acme-Alien-DontPanic - Test module for Alien::Base Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ppisar.fedorapeople.org/perl-Acme-Alien-DontPanic/perl-Acme-Alien-Do... SRPM URL: https://ppisar.fedorapeople.org/perl-Acme-Alien-DontPanic/perl-Acme-Alien-Do... Description: This Perl module is a toy module to test the efficacy of the Alien::Base system.
Fedora Account System Username: ppisar
https://bugzilla.redhat.com/show_bug.cgi?id=1487632
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1487611
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1487611 [Bug 1487611] Review Request: dontpanic - Very simple library and executable used in testing Alien::Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487632
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Hello,
- make and findutils are not needed as BR.
- dontpanic contains an rpath:
dontpanic.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dontpanic ['/builddir/build/BUILD/dontpanic-1.00/src/.libs']
You need to remove it, see https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make findutils See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/dontpanic/review- dontpanic/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(powerline- go), /usr/lib64/pkgconfig(pkgconf-pkg-config) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dontpanic-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: dontpanic-1.00-1.fc28.x86_64.rpm dontpanic-devel-1.00-1.fc28.x86_64.rpm dontpanic-debuginfo-1.00-1.fc28.x86_64.rpm dontpanic-1.00-1.fc28.src.rpm dontpanic.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dontpanic ['/builddir/build/BUILD/dontpanic-1.00/src/.libs'] dontpanic.x86_64: W: no-documentation dontpanic.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dontpanic.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dontpanic.x86_64: W: no-manual-page-for-binary dontpanic dontpanic-devel.x86_64: W: only-non-binary-in-usr-lib dontpanic-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 6 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1487632
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Sorry I paste in the wrong page.
For this package, everything is good, you should just ask upstream for a LICENSE file.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Perl". 9 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/perl- Acme-Alien-DontPanic/review-perl-Acme-Alien-DontPanic/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/auto/share/dist(perl-DBICx-AutoDoc, perl- Pegex, perl-DepGen-Perl-Tests, perl-Lingua-EN-Alphabet-Shaw, perl- Text-VimColor, perl-Shipwright, perl-PDF-Create, perl-MooX-Options, perl-Padre, perl-SQL-Translator, perl-File-ShareDir, perl-DateTime- Locale, perl-HTML-FormHandler, perl-Plack-Test, perl-Catalyst-Devel, perl-Inline-C, perl-Dancer2, perl-RDF-NS, perl-TestML, perl-Module- Manifest-Skip, perl-Inline-Module, perl-HTML-FormFu, perl-Module- Starter-Plugin-CGIApp, pangzero), /usr/share/perl5/vendor_perl/Acme (perl-Acme-PlayCode), /usr/share/perl5/vendor_perl/auto(perl-Dist- Zilla, perl-WebService-Rajce, perl-Data-Uniqid, perl-DBICx-AutoDoc, perl-Net-Whois-IP, perl-Padre, perl-Lingua-EN-Alphabet-Shaw, perl- Text-VimColor, perl-Shipwright, perl-Config-Simple, perl-App-PFT, perl-PDF-Reuse, perl-Log-Agent, perl-Graph, perl-Data-Flow, perl-MooX- Options, pangzero, perl-CDDB_get, perl-SQL-Translator, perl-CGI- Application-Plugin-SuperForm, perl-HTML-FormFu, perl-File-ShareDir, perl-PDF-Create, perl-Tree-R, perl-DateTime-Locale, perl-WWW- Babelfish, perl-HTML-FormHandler, perl-SOCKS, perl-Affix- Infix2Postfix, perl-Catalyst-Devel, perl-LWP-Authen-Negotiate, perl- Net-Telnet-Cisco, perl-Crypt-CAST5_PP, perl-Dancer2, perl-Pegex, perl- Ace, perl-ORLite-Mirror, perl-RDF-NS, perl-TestML, perl-Module- Manifest-Skip, perl-Inline-Module, perl-Net-IPv4Addr, perl-Data- TreeDumper-Renderer-GTK, perl-Memoize-ExpireLRU, perl-Module-Starter- Plugin-CGIApp, perl-QWizard, perl-Net-Lite-FTP, perl-DepGen-Perl- Tests), /usr/share/perl5/vendor_perl/auto/share(perl-Dist-Zilla, perl- DBICx-AutoDoc, perl-Pegex, pangzero, perl-Lingua-EN-Alphabet-Shaw, perl-Text-VimColor, perl-Shipwright, perl-App-PFT, perl-PDF-Create, perl-MooX-Options, perl-Padre, perl-SQL-Translator, perl-File- ShareDir, perl-DateTime-Locale, perl-HTML-FormHandler, perl-Plack- Test, perl-Catalyst-Devel, perl-Inline-C, perl-Dancer2, perl-ORLite- Mirror, perl-RDF-NS, perl-TestML, perl-Module-Manifest-Skip, perl- Inline-Module, perl-HTML-FormFu, perl-Module-Starter-Plugin-CGIApp, perl-DepGen-Perl-Tests) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned.
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: perl-Acme-Alien-DontPanic-0.044-1.fc28.noarch.rpm perl-Acme-Alien-DontPanic-0.044-1.fc28.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1487632
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Acme-Alien-DontPanic
https://bugzilla.redhat.com/show_bug.cgi?id=1487632 Bug 1487632 depends on bug 1487611, which changed state.
Bug 1487611 Summary: Review Request: dontpanic - Very simple library and executable used in testing Alien::Base https://bugzilla.redhat.com/show_bug.cgi?id=1487611
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1487632
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |perl-Acme-Alien-DontPanic-0 | |.044-1.fc28 Resolution|--- |RAWHIDE Last Closed| |2017-09-05 03:05:12
--- Comment #4 from Petr Pisar ppisar@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com