[Bug 457543] Review Request: perl-IPTables-Parse - A Perl extension for parsing iptables firewall rulesets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=457543

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #1 from Parag AN(पराग)   2008-08-04 00:59:44 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=756386
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
03fcd2d010db1b7190f7e257124cb278  IPTables-Parse-0.6.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.00 usr  0.00 sys +  0.01 cusr  0.00
csys =  0.01 CPU)
+ Package  perl-IPTables-Parse-0.6-1.fc10 =>
  Provides:  perl(IPTables::Parse) = 0.5
  Requires: perl >= 0:5.006 perl(Carp) perl(strict) perl(vars) perl(warnings)

APPROVED.