https://bugzilla.redhat.com/show_bug.cgi?id=1794564
Bug ID: 1794564 Summary: Review Request: babeltrace2 - A trace manipulation toolkit Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mjeanson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mjeanson.fedorapeople.org/babeltrace2/babeltrace2.spec SRPM URL: https://mjeanson.fedorapeople.org/babeltrace2/babeltrace2-2.0.0-1.fc32.src.r... Description: The Babeltrace 2 project offers a library with a C API, Python 3 bindings, and a command-line tool which makes it very easy for mere mortals to view, convert, transform, and analyze traces.
Babeltrace 2 is also the reference parser implementation of the Common Trace Format (CTF), a very versatile trace format followed by various tracers and tools such as LTTng and barectf.
Fedora Account System Username: mjeanson
This package is required because the API and the basename of the library have changed since babeltrace1, current dependencies like gdb and ceph will need to be ported to this new API and both package will have to be co-installable for a while.
https://bugzilla.redhat.com/show_bug.cgi?id=1794564
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hiwkby@yahoo.com Assignee|nobody@fedoraproject.org |hiwkby@yahoo.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1794564
--- Comment #1 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Michael,
Please see the comments.
1. Architecture s390x should be listed in the spec in ExcludeArch if this package doesn't support the s390x architecture. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_bui...
I found a build error on s390x architecture in a Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41310129
2. python3-bt2's description python3-bt2 package should have a descrption. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_desc...
3. License The base package, which is "babeltrace2" in this case, should include the upstream license file. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming
This package should contain a comment explaining the multiple licensing breakdown. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Best Regards, Hirotaka Wakabayashi
https://bugzilla.redhat.com/show_bug.cgi?id=1794564
--- Comment #2 from Michael Jeanson mjeanson@gmail.com --- Hi,
I've uploaded a new version of the package addressing your comments: Spec URL: https://mjeanson.fedorapeople.org/babeltrace2/babeltrace2.spec SRPM URL: https://mjeanson.fedorapeople.org/babeltrace2/babeltrace2-2.0.0-2.fc32.src.r...
Here is the corresponding koji scratch build : https://koji.fedoraproject.org/koji/taskinfo?taskID=41368542
It now successfully builds on all architectures.
Regards,
Michael
https://bugzilla.redhat.com/show_bug.cgi?id=1794564
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, Michael
Package approved.
Thanks you for your work. I'm sorry for my late response. Attached is a copy of rpmlint in my local environment.
Regards, Hirotaka Wakabayashi
``` # rpmlint ~/rpmbuild/SRPMS/babeltrace2-2.0.0-2.fc31.src.rpm babeltrace2.src: W: spelling-error %description -l en_US Babeltrace -> Babel trace, Babel-trace, Traceable babeltrace2.src: W: spelling-error %description -l en_US barectf -> barefoot babeltrace2.src:76: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 76)
# rpmlint ~/rpmbuild/RPMS/x86_64/babeltrace2-2.0.0-2.fc31.x86_64.rpm babeltrace2.x86_64: W: spelling-error %description -l en_US Babeltrace -> Babel trace, Babel-trace, Traceable babeltrace2.x86_64: W: spelling-error %description -l en_US barectf -> barefoot 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# rpmlint ~/rpmbuild/RPMS/x86_64/libbabeltrace2-devel-2.0.0-2.fc31.x86_64.rpm libbabeltrace2-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# rpmlint ~/rpmbuild/RPMS/x86_64/libbabeltrace2-2.0.0-2.fc31.x86_64.rpm libbabeltrace2.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# rpmlint ~/rpmbuild/RPMS/x86_64/python3-bt2-2.0.0-2.fc31.x86_64.rpm python3-bt2.x86_64: W: summary-not-capitalized C libbabeltrace2 python bindings python3-bt2.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ```
https://bugzilla.redhat.com/show_bug.cgi?id=1794564
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/babeltrace2
https://bugzilla.redhat.com/show_bug.cgi?id=1794564
Michael Jeanson mjeanson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-02-10 18:50:03
--- Comment #5 from Michael Jeanson mjeanson@gmail.com --- Thanks!
package-review@lists.fedoraproject.org