[Bug 1773280] New: Review Request: golang-github-pkg-browser - A Go library for openning browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Bug ID: 1773280 Summary: Review Request: golang-github-pkg-browser - A Go library for openning browsers Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: thom@sfedb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gist.githubusercontent.com/thomasfedb/2fdde1570b43e8ea373bce5b5402db... SRPM URL: https://gist.github.com/thomasfedb/2fdde1570b43e8ea373bce5b5402db47/raw/b627... Description: A Go library for openning browsers. Packaging as a dependency for the Go Todoist CLI. Fedora Account System Username: thomasfedb
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- The Summary is too long: "Package browser provides" is not needed.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "BSD 2-clause "Simplified" License", "Unknown or generated". 9 files have unknown license. Detailed output of licensecheck in 1773280-golang-github-pkg-browser/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-pkg-browser-0-0.1.20191117git0a3d74b.fc32.src.rpm golang-github-pkg-browser.src: W: spelling-error Summary(en_US) urls -> curls, purls, hurls golang-github-pkg-browser.src: E: summary-too-long C Package browser provides helpers to open files, readers, and urls in a browser window golang-github-pkg-browser.src: W: spelling-error %description -l en_US urls -> curls, purls, hurls golang-github-pkg-browser.src: W: no-%build-section 1 packages and 0 specfiles checked; 2 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/pkg/browser/archive/0a3d74bf9ce488f035cf5bc36f753a711bc74... : CHECKSUM(SHA256) this package : 75874c371714d65270c9f9a63d2ab39ffc8ded439364989119070b6f0f857b09 CHECKSUM(SHA256) upstream package : 75874c371714d65270c9f9a63d2ab39ffc8ded439364989119070b6f0f857b09
Requires -------- go-filesystem rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Provides -------- golang(github.com/pkg/browser) = 0-0.1.20191117git0a3d74b.fc32 golang(github.com/pkg/browser)(commit=0a3d74bf9ce488f035cf5bc36f753a711bc74334) = 0-0.1.20191117git0a3d74b.fc32 golang-github-pkg-browser-devel = 0-0.1.20191117git0a3d74b.fc32 golang-ipath(github.com/pkg/browser) = 0-0.1.20191117git0a3d74b.fc32 golang-ipath(github.com/pkg/browser)(commit=0a3d74bf9ce488f035cf5bc36f753a711bc74334) = 0-0.1.20191117git0a3d74b.fc32
Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1773280 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api Disabled plugins: C/C++, Ocaml, fonts, SugarActivity, Java, Perl, Python, Haskell, PHP, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Thomas Drake-Brockman thom@sfedb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #2 from Thomas Drake-Brockman thom@sfedb.com --- I will correct the description text.
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Thomas Drake-Brockman thom@sfedb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(quantum.analyst@g | |mail.com)
--- Comment #3 from Thomas Drake-Brockman thom@sfedb.com --- Revised description text, now reads: "Helpers to open files, readers, and urls in a browser" Thanks for the review, let me know if you're happy.
Spec URL: https://gist.github.com/thomasfedb/2fdde1570b43e8ea373bce5b5402db47/raw/3af2... SRPM URL: https://gist.github.com/thomasfedb/2fdde1570b43e8ea373bce5b5402db47/raw/3af2...
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |quantum.analyst@gmail.com Flags|fedora-review? |fedora-review+ |needinfo?(quantum.analyst@g | |mail.com) |
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- It wasn't necessary to shrink the description too; only the summary was too long. But it's fine either way.
Please don't set fedora-review unless you're reviewing.
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pkg-browser
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Ben Cotton bcotton@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |EOL Last Closed| |2019-11-27 14:17:10
--- Comment #6 from Ben Cotton bcotton@redhat.com --- Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug.
Thank you for reporting this bug and we are sorry it could not be fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Ben Cotton bcotton@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |POST Resolution|EOL |--- Keywords| |Reopened
--- Comment #7 from Ben Cotton bcotton@redhat.com --- This bug was accidentally closed due to a query error. Reopening.
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-6dbfbddec3 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6dbfbddec3
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
Thomas Drake-Brockman thom@sfedb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed|2019-11-27 14:17:10 |2019-11-28 14:11:24
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-pkg-browser-0-0.1.20191128git0a3d74b.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0ea2a561c8
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-pkg-browser-0-0.1.20191128git0a3d74b.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6dbfbddec3
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-pkg-browser-0-0.1.20191128git0a3d74b.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1773280
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-pkg-browser-0-0.1.20191128git0a3d74b.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com