https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Bug ID: 1264653 Summary: Review Request: php-guzzlehttp-guzzle5 - PHP HTTP client and webservice framework (5.x) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: shawn.iwinski@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/60723ae205a2d2dadaa6567b5149...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-guzzle5-5.3.0-4.fc22....
Description: Guzzle is a PHP HTTP client that makes it easy to work with HTTP/1.1 and takes the pain out of consuming web services.
* Pluggable HTTP adapters that can send requests serially or in parallel * Doesn't require cURL, but uses cURL by default * Streams data for both uploads and downloads * Provides event hooks & plugins for cookies, caching, logging, OAuth, mocks, etc * Keep-Alive & connection pooling * SSL Verification * Automatic decompression of response bodies * Streaming multipart file uploads * Connection timeouts
**** NOTE: This is major version 5.x of php-guzzlehttp-guzzle. If you need a **** newer major version, install php-guzzlehttp-guzzle instead.
Fedora Account System Username: siwinski
---
Many packages still require php-guzzlehttp-guzzle version 5.x so before updating that package to 6.x, this package will provide the 5.x version.
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1239252 Alias| |php-guzzlehttp-guzzle5
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1239252 [Bug 1239252] php-guzzlehttp-guzzle-6.1.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Of course... same questions that for php-aws-sdk2 (#1264654)
Seems only used by php-aws-sdk.
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- Sorry, "package" was the wrong term to use here. Many projects I have seen upstream have not updated to AWS API v3 or Guzzle v6 yet (I still find "new" projects using Guzzle v3!) so I would like to keep both of these package versions available while still being able to update the main RPM packages to their latest version.
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |php-guzzlehttp-guzzle5 - |php-guzzlehttp-guzzle6 - |PHP HTTP client and |PHP HTTP client |webservice framework (5.x) | Alias|php-guzzlehttp-guzzle5 |php-guzzlehttp-guzzle6
--- Comment #3 from Shawn Iwinski shawn@iwin.ski --- Version 6 instead of version 5.
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/ffc22fed958144d9aef034b3233b...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-guzzle6-6.1.1-1.fc23....
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- remi's scratch build of php-guzzlehttp-guzzle6-6.1.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12096822
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Created attachment 1103047 --> https://bugzilla.redhat.com/attachment.cgi?id=1103047&action=edit phpci.log
phpCompatInfo version 4.5.2 DB built Nov 25 2015 18:15:42 CET static analyze results
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Created attachment 1103048 --> https://bugzilla.redhat.com/attachment.cgi?id=1103048&action=edit review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #7 from Remi Collet fedora@famillecollet.com --- [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php/GuzzleHttp6
Notice: I have absolutely no idea what is the best path for such "dual-version" libraries. - does it make sense to have it in /usr/share/php (where we are trying to preserve a PSR-0 tree) ? - could a separate tree be better ? (/usr/share/php-guzzlehttp-guzzle6/GuzzleHttp...) - perhaps we should expose the autoloader path in some rpm macro
Really not a blocker, just my thoughts of the day... (/me should try to shutdown his brain...)
Just fix the trivial blocker, everything else is ok.
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #8 from Shawn Iwinski shawn@iwin.ski --- (In reply to Remi Collet from comment #7)
[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php/GuzzleHttp6
Updated
Diff: https://github.com/siwinski/rpms/commit/d61ec0e212076f3029c41fe85e68d34fadfb...
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/d61ec0e212076f3029c41fe85e68...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-guzzle6-6.1.1-2.fc23....
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Shawn Iwinski shawn@iwin.ski changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1302909 (drupal8)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1302909 [Bug 1302909] Review Request: drupal8 - An open source content management platform
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #9 from Remi Collet fedora@famillecollet.com --- [x]: Package must own all directories that it creates.
=== APPROVED ===
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-guzzlehttp-guzzle6
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #11 from Shawn Iwinski shawn@iwin.ski --- THANKS for the review @Remi
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e0f762e8d
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e0f762e8d
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3f370291d
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-02-07 22:22:54
https://bugzilla.redhat.com/show_bug.cgi?id=1264653
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-guzzlehttp-guzzle6-6.1.1-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org