[Bug 1272054] New: Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

Bug ID: 1272054
           Summary: Review Request: perl-Roman - Functions for converting
                    between Roman and Arabic numerals
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://jplesnik.fedorapeople.org/perl-Roman/perl-Roman.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Roman/perl-Roman-1.24-1.fc24.src.rpm

Description:
This package provides some functions which help conversion of numeric
notation between Roman and Arabic.

Fedora Account System Username: [e-mail]

Package is required by perl-HTML-Toc.

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=219036

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

--- Comment #1 from Upstream Release Monitoring  ---
ppisar's scratch build of perl-Roman-1.24-1.fc24.src.rpm for f24 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11470869

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #2 from Petr Pisar  ---
URL and Source0 are usable. Ok.
Source archive is original (SHA-256:
3080375bf5f96cb15310d1870a75472dc1fd2371273c6a546b81401b6f674a28).
License verified from lib/Roman.pm, README. Ok.
Summary verified from lib/Roman.pm. Ok
Description verified from lib/Roman.pm. Ok.
No XS code, noarch BuildArch is Ok.

TODO: Constrain `perl(Exporter)' BuildRequires with `>= 5.57' (META.json:39).

All tests pass. Ok.

$ rpmlint perl-Roman.spec ../SRPMS/perl-Roman-1.24-1.fc24.src.rpm
../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Oct 16 09:52
/usr/share/doc/perl-Roman
-rw-r--r--    1 root    root                      757 Oct 16 09:52
/usr/share/doc/perl-Roman/Changes
-rw-r--r--    1 root    root                     1395 Oct 16 09:52
/usr/share/doc/perl-Roman/README
-rw-r--r--    1 root    root                     2145 Oct 16 09:52
/usr/share/man/man3/Roman.3pm.gz
-rw-r--r--    1 root    root                     3920 Mar  1  2015
/usr/share/perl5/vendor_perl/Roman.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm | sort
-f | uniq -c
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Constrain `perl(Exporter)' Requires with `>= 5.57' (META.json:39).

$ rpm -q --provides -p ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm | sort
-f | uniq -c
      1 perl(Roman) = 1.24
      1 perl-Roman = 1.24-1.fc24
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F24
(http://koji.fedoraproject.org/koji/taskinfo?taskID=11470869). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please consider fixing the `TODO' items before building the package.
Resolution: Package APPROVED.

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED
   Fixed In Version|                            |perl-Roman-1.24-1.fc24

--- Comment #3 from Jitka Plesnikova  ---
Thank you for the review and the repository.

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

--- Comment #4 from Fedora Update System  ---
perl-Roman-1.24-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-c5f7e658d0

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #5 from Fedora Update System  ---
perl-Roman-1.24-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update perl-Roman'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-c5f7e658d0

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

--- Comment #6 from Fedora Update System  ---
perl-Roman-1.24-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

[Bug 1272054] Review Request: perl-Roman - Functions for converting between Roman and Arabic numerals

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272054

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2015-10-31 22:36:04