9:52 a.m.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
https://bugzilla.redhat.com/show_bug.cgi?id=768989
Summary: Review Request: geronimo-jaspic-spec - Java
Authentication SPI for Containers
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: sochotni(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Spec URL: http://sochotni.fedorapeople.org/packages/geronimo-jaspic-spec.spec
SRPM URL:
http://sochotni.fedorapeople.org/packages/geronimo-jaspic-spec-1.0-1.fc16...
Description:
Java Authentication Service Provider Interface for Containers (JSR-196) api.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:33 a.m.
New subject: [Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768989
Alexander Kurtakov <akurtako(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |akurtako(a)redhat.com
AssignedTo|nobody(a)fedoraproject.org |akurtako(a)redhat.com
Flag| |fedora-review?
--- Comment #1 from Alexander Kurtakov <akurtako(a)redhat.com> 2011-12-19 11:33:58 EST
---
I'll do this one.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:11 a.m.
New subject: [Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768989
Alexander Kurtakov <akurtako(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #2 from Alexander Kurtakov <akurtako(a)redhat.com> 2011-12-20 11:11:53 EST
---
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
geronimo-jaspic-spec.noarch: W: spelling-error %description -l en_US api -> pi,
ape, apt
geronimo-jaspic-spec.src: W: spelling-error %description -l en_US api -> pi,
ape, apt
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: ASL 2.0
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package :c2919bc29383c2957fae36554db8031a
MD5SUM upstream package:c2919bc29383c2957fae36554db8031a
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates or must require other
packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[-] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:51 a.m.
New subject: [Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768989
Stanislav Ochotnicky <sochotni(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
--- Comment #3 from Stanislav Ochotnicky <sochotni(a)redhat.com> 2011-12-21 04:51:45
EST ---
New Package SCM Request
=======================
Package Name: geronimo-jaspic-spec
Short Description: Java Authentication SPI for Containers
Owners: sochotni
Branches:
InitialCC: java-sig
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:07 a.m.
New subject: [Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768989
--- Comment #4 from Jon Ciesla <limburgher(a)gmail.com> 2011-12-21 06:07:29 EST ---
Git done (by process-git-requests).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:43 a.m.
New subject: [Bug 768989] Review Request: geronimo-jaspic-spec - Java Authentication SPI for Containers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=768989
Stanislav Ochotnicky <sochotni(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |RAWHIDE
Last Closed| |2011-12-21 08:43:05
--- Comment #5 from Stanislav Ochotnicky <sochotni(a)redhat.com> 2011-12-21 08:43:05
EST ---
Built done, thanks for review & repo
https://koji.fedoraproject.org/koji/buildinfo?buildID=279677
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4539
days inactive
4541
days old
package-review@lists.fedoraproject.org
5 comments
1 participants
participants (1)
-
Red Hat Bugzilla