Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ghc-sendfile - Portable sendfile library
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Summary: Review Request: ghc-sendfile - Portable sendfile library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: petersen@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://petersen.fedorapeople.org/reviews/ghc-sendfile/ghc-sendfile.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-sendfile/ghc-sendfile-0.7.6-1.f... Description: A portable sendfile library used by the Happstack webserver
http://koji.fedoraproject.org/koji/taskinfo?taskID=3988458
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-haskell-list@redhat. | |com Status Whiteboard| |Ready
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |ghc-sendfile
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #1 from Jens Petersen petersen@redhat.com 2012-04-13 11:12:17 EDT --- This should be the last dependency for happstack-server.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |812699
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lakshminaras2002@gmail.com AssignedTo|nobody@fedoraproject.org |lakshminaras2002@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #2 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2012-05-05 02:44:20 EDT --- [+]MUST: rpmlint must be run on every package. The output should be posted in the review. rpmlint -i ghc-sendfile-0.7.6-1.fc15.x86_64.rpm ghc-sendfile-0.7.6-1.fc15.src.rpm ghc-sendfile-devel-0.7.6-1.fc15.x86_64.rpm ../ghc-sendfile.spec ghc-sendfile.x86_64: W: spelling-error %description -l en_US haskell -> Haskell The value of this tag appears to be misspelled. Please double-check.
ghc-sendfile.src: W: spelling-error %description -l en_US haskell -> Haskell The value of this tag appears to be misspelled. Please double-check.
ghc-sendfile-devel.x86_64: W: spelling-error %description -l en_US haskell -> Haskell The value of this tag appears to be misspelled. Please double-check.
3 packages and 1 specfiles checked; 0 errors, 3 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines. [+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec [+]MUST: The package must meet the Packaging Guidelines. Naming-Yes Version-release - Matches No prebuilt external bits - OK Spec legibity - OK Package template - OK Arch support - OK Libexecdir - OK rpmlint - yes changelogs - OK Source url tag - OK, validated. Build Requires list - OK Summary and description - OK API documentation - OK, in devel package.
[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. BSD license [+]MUST: The License field in the package spec file must match the actual license. [+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. LICENSE file is included. [+]MUST: The spec file must be written in American English. [+]MUST: The spec file for the package MUST be legible. [+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum sendfile-0.7.6.tar.gz 4dea8d9f853fee4797f81e74791bd09e sendfile-0.7.6.tar.gz
md5sum ghc-sendfile-0.7.6-1.fc16.src/sendfile-0.7.6.tar.gz 4dea8d9f853fee4797f81e74791bd09e ghc-sendfile-0.7.6-1.fc16.src/sendfile-0.7.6.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+]MUST: All build dependencies must be listed in BuildRequires. [+]MUST: Packages must NOT bundle copies of system libraries. Checked with rpmquery --list [NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [+]MUST: A package must own all directories that it creates. Checked with rpmquery --whatprovides [+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+]MUST: Permissions on files must be set properly. Checked with ls -lR [+]MUST: Each package must consistently use macros. [+]MUST: The package must contain code, or permissible content. [+]MUST: Large documentation files must go in a -doc subpackage. [+]MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release} rpm -e ghc-sendfile-0.7.6-1.fc15.x86_64 error: Failed dependencies: ghc(sendfile-0.7.6) = d2baade88e666ebbe0f254e473584d8d is needed by (installed) ghc-sendfile-devel-0.7.6-1.fc15.x86_64 ghc-sendfile = 0.7.6-1.fc15 is needed by (installed) ghc-sendfile-devel-0.7.6-1.fc15.x86_64 [+]MUST: Packages must not own files or directories already owned by other packages. [+]MUST: All filenames in rpm packages must be valid UTF-8.
Should items [+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+]SHOULD: The reviewer should test that the package functions as described. Installs fine. Loaded Network.Socket.SendFile into ghci. Loads fine. [+]SHOULD: If scriptlets are used, those scriptlets must be sane.
cabal2spec-diff is OK.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|Ready | Flag| |fedora-cvs?
--- Comment #3 from Jens Petersen petersen@redhat.com 2012-05-05 21:40:36 EDT --- Thank you for the review. :)
New Package SCM Request ======================= Package Name: ghc-sendfile Short Description: Portable sendfile library Owners: petersen Branches: f17 f16 el6 InitialCC: haskell-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #4 from Jon Ciesla limburgher@gmail.com 2012-05-06 16:59:07 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2012-05-06 21:47:51 EDT --- ghc-sendfile-0.7.6-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-sendfile-0.7.6-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2012-05-06 21:48:01 EDT --- ghc-sendfile-0.7.6-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-sendfile-0.7.6-1.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2012-05-07 18:25:24 EDT --- ghc-sendfile-0.7.6-1.fc17 has been pushed to the Fedora 17 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #8 from Jens Petersen petersen@redhat.com 2012-05-13 22:22:03 EDT --- Sorry might as well do f15 too, thanks!
Package Change Request ====================== Package Name: ghc-sendfile New Branches: f15 Owners: petersen InitialCC: haskell-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #9 from Jon Ciesla limburgher@gmail.com 2012-05-14 08:03:11 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-05-14 20:58:40 EDT --- ghc-sendfile-0.7.6-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-sendfile-0.7.6-1.fc15
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-05-26 03:16:24
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- ghc-sendfile-0.7.6-1.fc17, ghc-happstack-server-7.0.0-2.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- ghc-sendfile-0.7.6-1.fc16, ghc-happstack-server-7.0.0-2.fc16 has been pushed to the Fedora 16 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- ghc-sendfile-0.7.6-1.fc15, ghc-happstack-server-7.0.0-2.fc15 has been pushed to the Fedora 15 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=812384
Shakthi Kannan shakthimaan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mathstuf@gmail.com
--- Comment #14 from Shakthi Kannan shakthimaan@gmail.com --- *** Bug 630298 has been marked as a duplicate of this bug. ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla