[Bug 1301253] New: Review Request: color - A string colorizer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253

Bug ID: 1301253
           Summary: Review Request: color - A string colorizer
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://terrydunn.org/color/color.spec
SRPM URL: http://terrydunn.org/color/color-0.2.1-1.fc23.src.rpm
Description: This program uses ANSI escape codes to colorize a string passed to
it either by argv or stdin.
Fedora Account System Username: awd123

[Bug 1301253] Review Request: color - A string colorizer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253

Austin Dunn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/awd123/c
                   |                            |olor

[Bug 1301253] Review Request: color - A string colorizer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253

Brandon Thomas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Brandon Thomas  ---
This is not an official review, and this does not effect the status of the
review request.
* It looks like a period slipped into the packages Summary.
* I don't believe that Amusements/Games" is a valid group.
* "make %{?_smp_mflags}" can be replaced with "%make_build".
* You don't need to specify the packager.
* You probably want the install and ln command to be in the "%install" section.
* You might want to consider including a change log at the end of your file.

[Bug 1301253] Review Request: color - A string colorizer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253

--- Comment #2 from Austin Dunn  ---
(In reply to Brandon Thomas from comment #1)

Thanks for the review!
> I don't believe that Amusements/Games" is a valid group.

Amusements/Games is a valid group. Try "cat /usr/share/doc/rpm/GROUPS"
> "make %{?_smp_mflags}" can be replaced with "%make_build".

That was in the vim .spec template, I will fix it in an update.
> You probably want the install and ln command to be in the "%install"

See above.

[Bug 1301253] Review Request: color - A string colorizer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |177841 (FE-NEEDSPONSOR)

--- Comment #3 from Petr Pisar  ---
You seems to not be in packager group yet, so I added the required "blocks"
dependency to this bug report. I hope some packager sponsor reach you. To the
package:

The License value is not valid one. See
https://fedoraproject.org/wiki/Licensing for the list of available
identifiers.

The program requires C compiler to build. You should build-requires gcc. See
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B.

The spec file invokes make command, so it should build-require it.

The LICENSE file must be packaged using %license macro. See
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1301253] Review Request: color - A string colorizer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301253

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1268697,
                   |                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1300465