[Bug 2357466] New: Review Request: python-scipy-doctest - Configurable, whitespace-insensitive, floating-point-aware doctest helpers
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
Bug ID: 2357466 Summary: Review Request: python-scipy-doctest - Configurable, whitespace-insensitive, floating-point-aware doctest helpers Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 1276941 (fedora-neuro,NeuroFedora) Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedorapeople.org/python-scipy-doctest.spec SRPM URL: https://music.fedorapeople.org/python-scipy-doctest-1.7.1-1.fc41.src.rpm
Description:
This project extends the standard library doctest module to allow flexibility and easy customization of finding, parsing and checking code examples in documentation.
Can be used either as drop-in doctest replacement or through the pytest integration. Uses a floating-point aware doctest checker by default.
Fedora Account System Username: music
This will enable us to run the doctests in python-shapely 2.1.0 and later, https://src.fedoraproject.org/rpms/python-shapely/pull-request/19. Since python-shapely is a neuro-sig package, this will also be a neuro-sig package.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://github.com/scipy/sc | |ipy_doctest
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8860287 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #2 from Ben Beasley code@musicinmybrain.net --- Updated patch for scipy 1.15.x forward-compatibility.
New Spec URL: https://music.fedorapeople.org/20250404/python-scipy-doctest.spec New SRPM URL: https://music.fedorapeople.org/20250404/python-scipy-doctest-1.7.1-1.fc41.sr...
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2083438 --> https://bugzilla.redhat.com/attachment.cgi?id=2083438&action=edit The .spec file difference from Copr build 8860287 to 8862012
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8862012 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sanjay.ankur@gmail.com Assignee|nobody@fedoraproject.org |sanjay.ankur@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- LGTM XXX APPROVED XXX
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-Clause License", "Unknown or generated". 26 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/2357466-python-scipy- doctest/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14764 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-scipy-doctest-1.7.1-1.fc43.noarch.rpm python-scipy-doctest-1.7.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe_hnjwsh')] checks: 32, packages: 2
python3-scipy-doctest.noarch: E: zero-length /usr/lib/python3.13/site-packages/scipy_doctest/tests/local_file.txt python-scipy-doctest.src: E: spelling-error ('whitespace', 'Summary(en_US) whitespace -> white space, white-space, whites pace') python-scipy-doctest.src: E: spelling-error ('pytest', '%description -l en_US pytest -> PyNEST, pertest, pettiest') python3-scipy-doctest.noarch: E: spelling-error ('whitespace', 'Summary(en_US) whitespace -> white space, white-space, whites pace') python3-scipy-doctest.noarch: E: spelling-error ('pytest', '%description -l en_US pytest -> PyNEST, pertest, pettiest') 2 packages and 0 specfiles checked; 5 errors, 0 warnings, 7 filtered, 5 badness; has taken 0.5 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python3-scipy-doctest.noarch: E: zero-length /usr/lib/python3.13/site-packages/scipy_doctest/tests/local_file.txt python3-scipy-doctest.noarch: E: spelling-error ('whitespace', 'Summary(en_US) whitespace -> white space, white-space, whites pace') python3-scipy-doctest.noarch: E: spelling-error ('pytest', '%description -l en_US pytest -> testes') 1 packages and 0 specfiles checked; 3 errors, 0 warnings, 3 filtered, 3 badness; has taken 0.1 s
Source checksums ---------------- https://files.pythonhosted.org/packages/source/s/scipy_doctest/scipy_doctest... : CHECKSUM(SHA256) this package : 0089de721c3c0f2a6a9fa34852b2b88b597d54afe336cb45b0bb130798ed7d69 CHECKSUM(SHA256) upstream package : 0089de721c3c0f2a6a9fa34852b2b88b597d54afe336cb45b0bb130798ed7d69
Requires -------- python3-scipy-doctest (rpmlib, GLIBC filtered): python(abi) python3.13dist(numpy) python3.13dist(pytest)
Provides -------- python3-scipy-doctest: python-scipy-doctest python3-scipy-doctest python3.13-scipy-doctest python3.13dist(scipy-doctest) python3dist(scipy-doctest)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2357466 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Java, Perl, fonts, Haskell, PHP, Ocaml, SugarActivity, R, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #6 from Ben Beasley code@musicinmybrain.net --- Thank you for the review! I’ll go ahead and import this and amend https://src.fedoraproject.org/rpms/python-shapely/pull-request/19 to use it. The Shapely 2.1.0 update is still blocked waiting on a new upstream release for python-geopandas, but we’ll be ready when the time comes.
https://release-monitoring.org/project/377940/
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-scipy-doctest
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-11803e35a8 (python-scipy-doctest-1.7.1-2.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-11803e35a8
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2025-05-03 04:08:12
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-11803e35a8 (python-scipy-doctest-1.7.1-2.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-06ad975656 (python-scipy-doctest-1.7.1-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-06ad975656
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-16ebc782a7 (python-scipy-doctest-1.7.1-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-16ebc782a7
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-d4c8b3c338 (python-scipy-doctest-1.7.1-1.el10_1) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-d4c8b3c338
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-06ad975656 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-06ad975656 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-06ad975656
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-16ebc782a7 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-16ebc782a7 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-16ebc782a7
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-d4c8b3c338 has been pushed to the Fedora EPEL 10.1 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-d4c8b3c338
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-06ad975656 (python-scipy-doctest-1.7.1-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-16ebc782a7 (python-scipy-doctest-1.7.1-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2357466
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-d4c8b3c338 (python-scipy-doctest-1.7.1-1.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com