https://bugzilla.redhat.com/show_bug.cgi?id=984806
Bug ID: 984806 Summary: Review Request: ghc-yesod-routes - Efficient routing for Yesod Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: petersen@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://petersen.fedorapeople.org//ghc-yesod-routes.spec SRPM URL: http://petersen.fedorapeople.org//ghc-yesod-routes-1.2.0.1-1.fc19.src.rpm
Description: Provides an efficient routing system, a parser and TH code generation.
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |haskell-devel@lists.fedorap | |roject.org Blocks| |925993 (ghc-yesod-core) Depends On| |983901 (ghc-path-pieces)
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |ghc-yesod-routes
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Shakthi Kannan shakthimaan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |shakthimaan@gmail.com Assignee|nobody@fedoraproject.org |shakthimaan@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Ready
https://bugzilla.redhat.com/show_bug.cgi?id=984806
--- Comment #1 from Jens Petersen petersen@redhat.com --- http://koji.fedoraproject.org/koji/taskinfo?taskID=5631667
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Shakthi Kannan shakthimaan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flags|fedora-review? |fedora-review+
--- Comment #2 from Shakthi Kannan shakthimaan@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= [-] Static libraries in -static subpackage, if present. Note: Archive *.a files found in ghc-yesod-routes-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 501760 bytes in 34 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages.
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: ghc-yesod-routes-1.2.0.1-1.fc20.x86_64.rpm ghc-yesod-routes-devel-1.2.0.1-1.fc20.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint ghc-yesod-routes-devel ghc-yesod-routes 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- ghc-yesod-routes-devel (rpmlib, GLIBC filtered): /bin/sh ghc(yesod-routes-1.2.0.1-74f2402891e7fdce680a0843869f134b) ghc-compiler ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc-devel(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2) ghc-devel(path-pieces-0.1.2-70ae946740222a12e48dbbe95189379e) ghc-devel(template-haskell-2.8.0.0-a3012803fde1dc362e555b35a1a78e6d) ghc-devel(text-0.11.3.1-e38859e86485c167fa7c9441789e7607) ghc-devel(vector-0.10.0.1-869166d5d49db46ce6c328ea5f8defbf) ghc-yesod-routes(x86-64)
ghc-yesod-routes (rpmlib, GLIBC filtered): ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2) ghc(path-pieces-0.1.2-70ae946740222a12e48dbbe95189379e) ghc(template-haskell-2.8.0.0-a3012803fde1dc362e555b35a1a78e6d) ghc(text-0.11.3.1-e38859e86485c167fa7c9441789e7607) ghc(vector-0.10.0.1-869166d5d49db46ce6c328ea5f8defbf) libHSarray-0.4.0.1-ghc7.6.3.so()(64bit) libHSbase-4.6.0.1-ghc7.6.3.so()(64bit) libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit) libHScontainers-0.5.0.0-ghc7.6.3.so()(64bit) libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit) libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit) libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit) libHSold-locale-1.0.0.5-ghc7.6.3.so()(64bit) libHSpath-pieces-0.1.2-ghc7.6.3.so()(64bit) libHSpretty-1.1.1.0-ghc7.6.3.so()(64bit) libHSprimitive-0.5.0.1-ghc7.6.3.so()(64bit) libHStemplate-haskell-2.8.0.0-ghc7.6.3.so()(64bit) libHStext-0.11.3.1-ghc7.6.3.so()(64bit) libHStime-1.4.0.1-ghc7.6.3.so()(64bit) libHSvector-0.10.0.1-ghc7.6.3.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) rtld(GNU_HASH)
Provides -------- ghc-yesod-routes-devel: ghc-devel(yesod-routes-1.2.0.1-74f2402891e7fdce680a0843869f134b) ghc-yesod-routes-devel ghc-yesod-routes-devel(x86-64)
ghc-yesod-routes: ghc(yesod-routes-1.2.0.1-74f2402891e7fdce680a0843869f134b) ghc-yesod-routes ghc-yesod-routes(x86-64) libHSyesod-routes-1.2.0.1-ghc7.6.3.so()(64bit)
Unversioned so-files -------------------- ghc-yesod-routes: /usr/lib64/ghc-7.6.3/yesod-routes-1.2.0.1/libHSyesod-routes-1.2.0.1-ghc7.6.3.so
Source checksums ---------------- http://hackage.haskell.org/packages/archive/yesod-routes/1.2.0.1/yesod-route... : CHECKSUM(SHA256) this package : 1f4540b1751f6b4132b18297c8982c063e91d3dba12a6164805c83c6d878e75e CHECKSUM(SHA256) upstream package : 1f4540b1751f6b4132b18297c8982c063e91d3dba12a6164805c83c6d878e75e
Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 984806 -m fedora-rawhide-x86_64
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |POST Whiteboard|Ready | Flags| |fedora-cvs?
--- Comment #3 from Jens Petersen petersen@redhat.com --- Thanks Shakthi
New Package SCM Request ======================= Package Name: ghc-yesod-routes Short Description: Efficient routing for Yesod Owners: petersen Branches: f19 f18 el6 InitialCC: haskell-sig
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=984806
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=984806
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- ghc-yesod-routes-1.2.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-yesod-routes-1.2.0.1-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- ghc-yesod-routes-1.2.0.1-1.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Bug 984806 depends on bug 983901, which changed state.
Bug 983901 Summary: Review Request: ghc-path-pieces - Components of paths https://bugzilla.redhat.com/show_bug.cgi?id=983901
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=984806
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |ghc-yesod-routes-1.2.0.1-1. | |fc19 Resolution|--- |ERRATA Last Closed| |2013-08-05 20:26:19
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- ghc-yesod-routes-1.2.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla