[Bug 2186547] New: Review Request: rust-openpgp-cert-d - Shared OpenPGP Certificate Directory
https://bugzilla.redhat.com/show_bug.cgi?id=2186547
Bug ID: 2186547 Summary: Review Request: rust-openpgp-cert-d - Shared OpenPGP Certificate Directory Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-openpgp-cert-d.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-openpgp-cert-d-0.1.0-1.fc38.src.rpm
Description: Shared OpenPGP Certificate Directory.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=99894249
https://bugzilla.redhat.com/show_bug.cgi?id=2186547
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/op | |enpgp-cert-d
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5779406 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2186547
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |h-k-81@hotmail.com Doc Type|--- |If docs needed, set a value CC| |h-k-81@hotmail.com Status|NEW |POST Flags| |fedora-review+
--- Comment #2 from blinxen h-k-81@hotmail.com --- Taking this review
General comments:
- Package was generated with rust2rpm and tests were deactivated - Deactivating tests makes sense here because the test data is not published with the crate. Is this intended? Should this be reported to upstream?
APPROVED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License". 9 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rust-openpgp-cert-d/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- openpgp-cert-d-devel , rust-openpgp-cert-d+default-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: rust-openpgp-cert-d-devel-0.1.0-1.fc39.noarch.rpm rust-openpgp-cert-d+default-devel-0.1.0-1.fc39.noarch.rpm rust-openpgp-cert-d-0.1.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjrafl5in')] checks: 31, packages: 3
rust-openpgp-cert-d+default-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2
rust-openpgp-cert-d+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s
Source checksums ---------------- https://crates.io/api/v1/crates/openpgp-cert-d/0.1.0/download#/openpgp-cert-... : CHECKSUM(SHA256) this package : ccaa2a2e4502a5daf19c5753250fc6e37daa1d06f866ec97cd5e3416e6d05883 CHECKSUM(SHA256) upstream package : ccaa2a2e4502a5daf19c5753250fc6e37daa1d06f866ec97cd5e3416e6d05883
Requires -------- rust-openpgp-cert-d-devel (rpmlib, GLIBC filtered): (crate(anyhow) >= 1.0.0 with crate(anyhow) < 2.0.0~) (crate(anyhow/std) >= 1.0.0 with crate(anyhow/std) < 2.0.0~) (crate(dirs) >= 4.0.0 with crate(dirs) < 5.0.0~) (crate(fd-lock) >= 3.0.0 with crate(fd-lock) < 4.0.0~) (crate(sha1collisiondetection) >= 0.2.0 with crate(sha1collisiondetection) < 0.3.0~) (crate(tempfile) >= 3.2.0 with crate(tempfile) < 4.0.0~) (crate(thiserror) >= 1.0.0 with crate(thiserror) < 2.0.0~) cargo
rust-openpgp-cert-d+default-devel (rpmlib, GLIBC filtered): cargo crate(openpgp-cert-d)
Provides -------- rust-openpgp-cert-d-devel: crate(openpgp-cert-d) rust-openpgp-cert-d-devel
rust-openpgp-cert-d+default-devel: crate(openpgp-cert-d/default) rust-openpgp-cert-d+default-devel
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-openpgp-cert-d --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, C/C++, Perl, Python, Java, Ocaml, Haskell, fonts, PHP, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2186547
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-openpgp-cert-d
https://bugzilla.redhat.com/show_bug.cgi?id=2186547
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
- Deactivating tests makes sense here because the test data is not published with the crate. Is this intended? Should this be reported to upstream?
This is maybe not intended, but a result of the upstream project's directory structure: https://gitlab.com/sequoia-pgp/pgp-cert-d
Changing this around so that the test files are included where necessary, not duplicated, and found at the correct paths in both upstream and downstream tests is non-trivial :(
https://bugzilla.redhat.com/show_bug.cgi?id=2186547
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|POST |CLOSED Last Closed| |2023-04-28 20:34:02
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-221bb8d031
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com