[Bug 1291403] New: Review Request: nodejs-os-homedir - An io.js 2.3.0 os.homedir() ponyfill
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
Bug ID: 1291403 Summary: Review Request: nodejs-os-homedir - An io.js 2.3.0 os.homedir() ponyfill Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-os-homedir/nodejs-os-homedi... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-os-homedir/nodejs-os-homedi... Description: An io.js 2.3.0 os.homedir() ponyfill Fedora Account System Username: jsmith
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@compton.nu Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
--- Comment #1 from Tom Hughes tom@compton.nu --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/tom/1291403 -nodejs-os-homedir/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: nodejs-os-homedir-1.0.1-1.fc24.noarch.rpm nodejs-os-homedir-1.0.1-1.fc24.src.rpm nodejs-os-homedir.noarch: W: spelling-error Summary(en_US) io -> oi, Io, ii nodejs-os-homedir.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-os-homedir.noarch: W: spelling-error Summary(en_US) ponyfill -> pony fill, pony-fill, ponytail nodejs-os-homedir.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii nodejs-os-homedir.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-os-homedir.noarch: W: spelling-error %description -l en_US ponyfill -> pony fill, pony-fill, ponytail nodejs-os-homedir.noarch: W: only-non-binary-in-usr-lib nodejs-os-homedir.src: W: spelling-error Summary(en_US) io -> oi, Io, ii nodejs-os-homedir.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-os-homedir.src: W: spelling-error Summary(en_US) ponyfill -> pony fill, pony-fill, ponytail nodejs-os-homedir.src: W: spelling-error %description -l en_US io -> oi, Io, ii nodejs-os-homedir.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-os-homedir.src: W: spelling-error %description -l en_US ponyfill -> pony fill, pony-fill, ponytail 2 packages and 0 specfiles checked; 0 errors, 13 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-os-homedir.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Diff spec file in url and in SRPM --------------------------------- --- /home/tom/1291403-nodejs-os-homedir/srpm/nodejs-os-homedir.spec 2015-12-15 19:09:01.443781578 +0000 +++ /home/tom/1291403-nodejs-os-homedir/srpm-unpacked/nodejs-os-homedir.spec 2015-12-14 19:42:47.000000000 +0000 @@ -41,4 +41,5 @@ %build # nothing to do! +%{__nodejs} -e 'require("./")'
%install @@ -52,5 +53,4 @@ %check %nodejs_symlink_deps --check -%{__nodejs} -e 'require("./")' %__nodejs test.js %endif
Requires -------- nodejs-os-homedir (rpmlib, GLIBC filtered): nodejs nodejs(engine)
Provides -------- nodejs-os-homedir: nodejs-os-homedir npm(os-homedir)
Source checksums ---------------- https://registry.npmjs.org/os-homedir/-/os-homedir-1.0.1.tgz : CHECKSUM(SHA256) this package : b71ca4fa8d83047209c923ca2d61ce7500a46f53698e66f283dd385774e196aa CHECKSUM(SHA256) upstream package : b71ca4fa8d83047209c923ca2d61ce7500a46f53698e66f283dd385774e196aa https://raw.githubusercontent.com/sindresorhus/os-homedir/13ff83fbd13ebe286a... : CHECKSUM(SHA256) this package : 24f783c2f7743c328839e6490f1f91a0ce0f4ef4ba10b3c631085af114d72b9e CHECKSUM(SHA256) upstream package : 24f783c2f7743c328839e6490f1f91a0ce0f4ef4ba10b3c631085af114d72b9e
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1291403 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
--- Comment #2 from Tom Hughes tom@compton.nu --- The tests are getting included in the package, and the test require should be in %check not %build (apart from anything else it needs to be after the symlink_deps call in general).
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
--- Comment #3 from Jared Smith jsmith.fedora@gmail.com --- Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-os-homedir/nodejs-os-homedi... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-os-homedir/nodejs-os-homedi...
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Tom Hughes tom@compton.nu --- Looks good now.
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-os-homedir
https://bugzilla.redhat.com/show_bug.cgi?id=1291403
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-08-04 06:47:02
--- Comment #6 from Jared Smith jsmith.fedora@gmail.com --- In rawhide, closing bug
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla