[Bug 469833] New: Review Request: perl-Math-BigInt-GMP - Use the GMP library for Math::BigInt routines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Math-BigInt-GMP - Use the GMP library for Math::BigInt routines
https://bugzilla.redhat.com/show_bug.cgi?id=469833
Summary: Review Request: perl-Math-BigInt-GMP - Use the GMP library for Math::BigInt routines Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: paul@city-fan.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.city-fan.org/~paul/extras/perl-Math-BigInt-GMP/perl-Math-BigInt-G... SRPM URL: http://www.city-fan.org/~paul/extras/perl-Math-BigInt-GMP/perl-Math-BigInt-G... Description:
Provides support for big integer calculations via means of the GMP C-library.
Math::BigInt::GMP provides its own XS layer to access the GMP C-library rather than using Math::GMP as an intermediate layer, an approach that reduces the memory footprint compared with the old approach used in earlier versions of Math::BigInt.
This package is needed to provide GMP support for Math::BigInt-using packages (such as perl-Crypt-DSA and perl-Crypt-DH) in Fedora 9 onwards, where the Math::BigInt implementation has changed and no longer uses the existing Math::GMP module.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cweyl@alumni.drew.edu Alias| |perl-Math-BigInt-GMP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review+
--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2008-11-07 09:30:33 EDT --- I followed the URL as usual when doing reviews and failed to notice that I had ended up at the Math-GMP page, which confused the hell out of me. I think you want URL: http://search.cpan.org/dist/Math-BigInt-GMP/ instead.
That's really the only thing I see wrong with this package; I'll approve it and you can fix up the URL when you check in.
* source files match upstream: 3f00fb0191b4343745b99f104a50f50a49fa7424fe70cc002f000465161a8eb4 Math-BigInt-GMP-1.24.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: GMP.so()(64bit) perl(Math::BigInt::GMP) = 1.24 perl-Math-BigInt-GMP = 1.24-1.fc10 perl-Math-BigInt-GMP(x86-64) = 1.24-1.fc10 = libgmp.so.3()(64bit) perl >= 0:5.006002 perl(:MODULE_COMPAT_5.10.0) perl(XSLoader) perl(strict) perl(vars)
* %check is present and all tests pass: All tests successful. Files=7, Tests=5530, 3 wallclock secs ( 0.51 usr 0.03 sys + 2.50 cusr 0.07 csys = 3.11 CPU)
* no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files.
APPROVED, just fix up the URL.
The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Paul Howarth paul@city-fan.org 2008-11-07 09:45:24 EDT --- New Package CVS Request ======================= Package Name: perl-Math-BigInt-GMP Short Description: Use the GMP library for Math::BigInt routines Owners: pghmcfc Branches: F-9 F-10 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
--- Comment #3 from Paul Howarth paul@city-fan.org 2008-11-07 09:46:37 EDT --- (In reply to comment #1)
I followed the URL as usual when doing reviews and failed to notice that I had ended up at the Math-GMP page, which confused the hell out of me. I think you want URL: http://search.cpan.org/dist/Math-BigInt-GMP/ instead.
That's really the only thing I see wrong with this package; I'll approve it and you can fix up the URL when you check in.
Good spot; guess which package spec I used as a template for this one...
Thanks for the review (again).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2008-11-07 16:36:29 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |steve@silug.org
--- Comment #5 from Paul Howarth paul@city-fan.org 2008-11-07 17:12:24 EDT --- OK so I came to check out perl-Math-BigInt-GMP from CVS and found that it was already there. Steven Pritchard is the owner of the package and it was reviewed in Bug #447191. I missed it because I checked for its existence using "yum install 'perl(Math::BigInt::GMP)'" on my Fedora 9 box and there were no matching packages. Steven has built it for Fedora 10/devel (at the time) but not F-9, and there's no point building it for anything older, though there are branches for F-8, EL-4, and EL-5.
It would appear that my new package request has made me the owner of the devel, F-10, and F-9 branches. What to do about this? Steven, shall we co-maintain this?
There may also be an issue to consider in the package database in that I was able to "take over" this package by accident, which probably should have been blocked.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
--- Comment #6 from Kevin Fenzi kevin@tummy.com 2008-11-07 17:59:51 EDT --- I have set it back to owned by steve until you guys can sort it out.
I usually catch things like this, but it's hard to note as the current tools just change things, they don't warn that the package already exists.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2008-11-07 18:04:38 EDT --- I did submit a patch to pkgdb-client to optionally work in an add-only mode; I don't know what became of it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
--- Comment #8 from Paul Howarth paul@city-fan.org 2008-11-08 04:04:39 EDT --- Steve, can you do a build of perl-Math-BigInt-GMP for F-9 as I need it for perl-Crypt-DSA perl-Crypt-DH?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |DUPLICATE Flag|fedora-review+ |
--- Comment #9 from Jason Tibbitts tibbs@math.uh.edu 2008-12-02 18:28:28 EDT --- I guess this should have been closed DUPLICATE initially, so I'll do that now.
*** This bug has been marked as a duplicate of 447191 ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
--- Comment #10 from Chris Weyl cweyl@alumni.drew.edu 2008-12-02 18:37:15 EDT --- (In reply to comment #8)
Steve, can you do a build of perl-Math-BigInt-GMP for F-9 as I need it for perl-Crypt-DSA perl-Crypt-DH?
I haven't seen any activity from Steve since mid-August or so; if you have superwizbangpackager membership (unsure of the exact name right now <grin>) I'd suggest filing a bug against it, then just submitting an update.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469833
--- Comment #11 from Paul Howarth paul@city-fan.org 2008-12-04 06:32:16 EDT --- (In reply to comment #10)
(In reply to comment #8)
Steve, can you do a build of perl-Math-BigInt-GMP for F-9 as I need it for perl-Crypt-DSA perl-Crypt-DH?
I haven't seen any activity from Steve since mid-August or so; if you have superwizbangpackager membership (unsure of the exact name right now <grin>) I'd suggest filing a bug against it, then just submitting an update.
Fortunately I'm a member of the superwizbangpackager group and perl-sig too so I've now built F-9 versions of perl-Math-BigInt-GMP and perl-Crypt-DSA/perl-Crypt-DH with a dependency on perl-Math-BigInt-GMP. See Bug #447191.
Steve's last blog post was in early October, and is titled "I'm not dead (yet)". Seems he's quite busy at work.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla