[Bug 1699030] New: Review Request: perl-Mail-AuthenticationResults - Object Oriented Authentication-Results Headers
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
Bug ID: 1699030 Summary: Review Request: perl-Mail-AuthenticationResults - Object Oriented Authentication-Results Headers Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: xavier@bachelot.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Mail-AuthenticationResults.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Mail-AuthenticationResults-1.2018... Description: Object Oriented Authentication-Results Headers Fedora Account System Username: xavierb
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |emmanuel@seyman.fr
--- Comment #1 from Xavier Bachelot xavier@bachelot.org --- This package will be needed for upcoming Mail::DKIM 0.55 https://rt.cpan.org/Public/Bug/Display.html?id=129066
Adding Mail::DKIM maintainer to cc:
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - %{__perl} → perl
- %{__perl} Makefile.PL INSTALLDIRS=vendor
→
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 OPTIMIZE="$RPM_OPT_FLAGS"
w/ BuildRequires: perl(ExtUtils::MakeMaker) >= 7.12
and:
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
→
%{make_install}
- As a result, not needed:
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ; find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ;
URL and Source addresses are Ok. Source archive (SHA-256: 7ff59a229db597cc89e3aa9c2459145092061da0b77012376f142eb653f53cbccfd0121c0) is original. Ok. Summary verified from lib/Mail/AuthenticationResults.pm. Ok. Description verified from lib/Mail/AuthenticationResults.pm. Ok. License verified from lib/Mail/AuthenticationResults.pm and README. Ok. No XS code, noarch BuildArch is Ok.
$ rpmlint perl-Mail-AuthenticationResults.spec review-perl-Mail-AuthenticationResults/results/perl-Mail-AuthenticationResults-1.20180923-1.fc31.noarch.rpm review-perl-Mail-AuthenticationResults/results/perl-Mail-AuthenticationResults-1.20180923-1.fc31.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpm -q -lv -p perl-Mail-AuthenticationResults-1.20180923-1.fc31.noarch.rpm 18:05:16 drwxr-xr-x 2 root root 0 Apr 13 18:02 /usr/share/doc/perl-Mail-AuthenticationResults -rw-r--r-- 1 root root 1304 Sep 23 2018 /usr/share/doc/perl-Mail-AuthenticationResults/Changes -rw-r--r-- 1 root root 1241 Sep 23 2018 /usr/share/doc/perl-Mail-AuthenticationResults/README -rw-r--r-- 1 root root 1074 Sep 23 2018 /usr/share/doc/perl-Mail-AuthenticationResults/README.md -rw-r--r-- 1 root root 457 Sep 23 2018 /usr/share/doc/perl-Mail-AuthenticationResults/dist.ini drwxr-xr-x 2 root root 0 Apr 13 18:02 /usr/share/licenses/perl-Mail-AuthenticationResults -rw-r--r-- 1 root root 18352 Sep 23 2018 /usr/share/licenses/perl-Mail-AuthenticationResults/LICENSE -rw-r--r-- 1 root root 1727 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults.3pm.gz -rw-r--r-- 1 root root 2044 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::FoldableHeader.3pm.gz -rw-r--r-- 1 root root 1835 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header.3pm.gz -rw-r--r-- 1 root root 1559 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header::AuthServID.3pm.gz -rw-r--r-- 1 root root 2536 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header::Base.3pm.gz -rw-r--r-- 1 root root 1405 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header::Comment.3pm.gz -rw-r--r-- 1 root root 1492 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header::Entry.3pm.gz -rw-r--r-- 1 root root 1421 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header::Group.3pm.gz -rw-r--r-- 1 root root 1480 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header::SubEntry.3pm.gz -rw-r--r-- 1 root root 1415 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Header::Version.3pm.gz -rw-r--r-- 1 root root 1536 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Parser.3pm.gz -rw-r--r-- 1 root root 1752 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Token.3pm.gz -rw-r--r-- 1 root root 1377 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Token::Assignment.3pm.gz -rw-r--r-- 1 root root 1368 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Token::Comment.3pm.gz -rw-r--r-- 1 root root 1373 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Token::QuotedString.3pm.gz -rw-r--r-- 1 root root 1369 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Token::Separator.3pm.gz -rw-r--r-- 1 root root 1366 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Token::Space.3pm.gz -rw-r--r-- 1 root root 1365 Apr 13 18:02 /usr/share/man/man3/Mail::AuthenticationResults::Token::String.3pm.gz drwxr-xr-x 2 root root 0 Apr 13 18:02 /usr/share/perl5/vendor_perl/Mail drwxr-xr-x 2 root root 0 Apr 13 18:02 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults -rw-r--r-- 1 root root 1714 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults.pm -rw-r--r-- 1 root root 9177 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/FoldableHeader.pm drwxr-xr-x 2 root root 0 Apr 13 18:02 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header -rw-r--r-- 1 root root 7502 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header.pm -rw-r--r-- 1 root root 2014 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header/AuthServID.pm -rw-r--r-- 1 root root 14118 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header/Base.pm -rw-r--r-- 1 root root 2491 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header/Comment.pm -rw-r--r-- 1 root root 1512 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header/Entry.pm -rw-r--r-- 1 root root 2570 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header/Group.pm -rw-r--r-- 1 root root 1379 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header/SubEntry.pm -rw-r--r-- 1 root root 1860 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Header/Version.pm -rw-r--r-- 1 root root 10210 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Parser.pm drwxr-xr-x 2 root root 0 Apr 13 18:02 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token -rw-r--r-- 1 root root 2440 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token.pm -rw-r--r-- 1 root root 1263 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token/Assignment.pm -rw-r--r-- 1 root root 1617 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token/Comment.pm -rw-r--r-- 1 root root 1517 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token/QuotedString.pm -rw-r--r-- 1 root root 1188 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token/Separator.pm -rw-r--r-- 1 root root 1126 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token/Space.pm -rw-r--r-- 1 root root 2201 Sep 23 2018 /usr/share/perl5/vendor_perl/Mail/AuthenticationResults/Token/String.pm File permissions and layout are Ok.
$ rpm -q --requires -p perl-Mail-AuthenticationResults-1.20180923-1.fc31.noarch.rpm | sort -f | uniq -c 18:05:57 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.8.0 1 perl(base) 1 perl(Carp) 1 perl(Mail::AuthenticationResults::FoldableHeader) 1 perl(Mail::AuthenticationResults::Header) 1 perl(Mail::AuthenticationResults::Header::AuthServID) 1 perl(Mail::AuthenticationResults::Header::Base) 1 perl(Mail::AuthenticationResults::Header::Comment) 1 perl(Mail::AuthenticationResults::Header::Entry) 1 perl(Mail::AuthenticationResults::Header::Group) 1 perl(Mail::AuthenticationResults::Header::SubEntry) 1 perl(Mail::AuthenticationResults::Header::Version) 1 perl(Mail::AuthenticationResults::Parser) 1 perl(Mail::AuthenticationResults::Token) 1 perl(Mail::AuthenticationResults::Token::Assignment) 1 perl(Mail::AuthenticationResults::Token::Comment) 1 perl(Mail::AuthenticationResults::Token::QuotedString) 1 perl(Mail::AuthenticationResults::Token::Separator) 1 perl(Mail::AuthenticationResults::Token::Space) 1 perl(Mail::AuthenticationResults::Token::String) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -q --provides -p perl-Mail-AuthenticationResults-1.20180923-1.fc31.noarch.rpm 18:09:11 perl(Mail::AuthenticationResults) = 1.20180923 perl(Mail::AuthenticationResults::FoldableHeader) = 1.20180923 perl(Mail::AuthenticationResults::Header) = 1.20180923 perl(Mail::AuthenticationResults::Header::AuthServID) = 1.20180923 perl(Mail::AuthenticationResults::Header::Base) = 1.20180923 perl(Mail::AuthenticationResults::Header::Comment) = 1.20180923 perl(Mail::AuthenticationResults::Header::Entry) = 1.20180923 perl(Mail::AuthenticationResults::Header::Group) = 1.20180923 perl(Mail::AuthenticationResults::Header::SubEntry) = 1.20180923 perl(Mail::AuthenticationResults::Header::Version) = 1.20180923 perl(Mail::AuthenticationResults::Parser) = 1.20180923 perl(Mail::AuthenticationResults::Token) = 1.20180923 perl(Mail::AuthenticationResults::Token::Assignment) = 1.20180923 perl(Mail::AuthenticationResults::Token::Comment) = 1.20180923 perl(Mail::AuthenticationResults::Token::QuotedString) = 1.20180923 perl(Mail::AuthenticationResults::Token::Separator) = 1.20180923 perl(Mail::AuthenticationResults::Token::Space) = 1.20180923 perl(Mail::AuthenticationResults::Token::String) = 1.20180923 perl-Mail-AuthenticationResults = 1.20180923-1.fc31 Binary provides are Ok.
Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=34150373). Ok
Resolution: Please fix the aforementioned points before approval.
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #3 from Xavier Bachelot xavier@bachelot.org --- (In reply to Robert-André Mauchin from comment #2)
- %{__perl} → perl
Fixed.
- %{__perl} Makefile.PL INSTALLDIRS=vendor
→
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 OPTIMIZE="$RPM_OPT_FLAGS"
w/ BuildRequires: perl(ExtUtils::MakeMaker) >= 7.12
and:
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
→
%{make_install}
- As a result, not needed:
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ; find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ;
This a noarch package so OPTIMIZE doesn't matter. I will build for EL6 and EL7, so I can't use NO_PACKLIST and NO_PERLLOCAL as ExtUtils::MakeMaker is 6.55 and 6.68.
Also, you didn't mention it, but I made use of %make_build instead of make %{?_smp_mflags}.
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Mail-AuthenticationResults.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Mail-AuthenticationResults-1.2018...
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Alrighty then package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mail-AuthenticationResults
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ed7b3b5e16
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1e8068981b
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5e075b474d
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e337575b3f
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1e8068981b
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e337575b3f
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ed7b3b5e16
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5e075b474d
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-04-24 22:58:37
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1699030
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- perl-Mail-AuthenticationResults-1.20180923-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com