[Bug 1427295] New: Review Request: container-storage-setup - Tool for setting up container runtimes storage
1:54 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
Bug ID: 1427295
Summary: Review Request: container-storage-setup - Tool for
setting up container runtimes storage
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: dwalsh(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://github.com/projectatomic/container-storage-setup
SRPM URL:
https://fedorapeople.org/~dwalsh/container-storage-setup-0.1.0-1.fc26.src...
Description: `container-storage-setup` is a script to configure COW File
systems like devicemapper and overlayfs. It is usually run via a systemd
service. For example `docker-storage-setup.service`, runs
`container-storage-setup` before the docker.service script starts the docker
daemon.
Fedora Account System Username: dwalsh(a)FEDORAPROJECT.ORG
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:56 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - Tool for setting up container runtimes storage
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #1 from Daniel Walsh <dwalsh(a)redhat.com> ---
container-storage-setup is a rewrite of docker-storage-setup so that it can be
used for other container runtimes. Specifically we want to use this for
CRI-O/ocid package as well as docker.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - Tool for setting up container runtimes storage
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
Lokesh Mandvekar <lsm5(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |lsm5(a)redhat.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:27 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - Tool for setting up container runtimes storage
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #2 from Lokesh Mandvekar <lsm5(a)redhat.com> ---
Spec URL:
https://raw.githubusercontent.com/projectatomic/container-storage-setup/m...
using raw spec url, fedora-review has trouble locating the spec with the URL in
description
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:31 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - Tool for setting up container runtimes storage
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #3 from Lokesh Mandvekar <lsm5(a)redhat.com> ---
results of fedora-review
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated". 42 files have
unknown
license. Detailed output of licensecheck in /home/lsm5/1427295
-container-storage-setup/licensecheck.txt
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[ ]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define csslibdir
%{_prefix}/lib/container-storage-setup
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: container-storage-setup-0.1.0-1.fc26.noarch.rpm
container-storage-setup-0.1.0-1.fc26.src.rpm
container-storage-setup.noarch: W: only-non-binary-in-usr-lib
container-storage-setup.src:3: E: hardcoded-library-path in
%{_prefix}/lib/container-storage-setup
2 packages and 0 specfiles checked; 1 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
container-storage-setup.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires
--------
container-storage-setup (rpmlib, GLIBC filtered):
/bin/bash
lvm2
systemd-units
xfsprogs
Provides
--------
container-storage-setup:
container-storage-setup
Source checksums
----------------
https://github.com/projectatomic/container-storage-setup/archive/79462e95...
:
CHECKSUM(SHA256) this package :
5267c9e8191ca377f9bb05ad30cbf071c902d5809da2042d1030885265e9e368
CHECKSUM(SHA256) upstream package :
5267c9e8191ca377f9bb05ad30cbf071c902d5809da2042d1030885265e9e368
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1427295
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:46 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - Tool for setting up container runtimes storage
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #4 from Lokesh Mandvekar <lsm5(a)redhat.com> ---
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated". 42 files have
unknown
license. Detailed output of licensecheck in /home/lsm5/1427295
-container-storage-setup/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define csslibdir
%{_prefix}/lib/container-storage-setup
Could you change %define csslibdir to %global csslibdir?
Also, I think README.md should be included in a %doc.
It'd be nice to have a LICENSE file with ASL 2.0 text in it. Right now there's
just ASL 2.0 text included in the c-s-s.sh file. Just to make our license loud
and clear.
Everything else looks ok and almost ready for approval.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:55 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - A simple service to setup container storage
devices
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
Lokesh Mandvekar <lsm5(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review Request: |Review Request:
|container-storage-setup - |container-storage-setup -
|Tool for setting up |A simple service to setup
|container runtimes storage |container storage devices
--- Comment #5 from Lokesh Mandvekar <lsm5(a)redhat.com> ---
Editing bug summary to make it consistent with %{summary} in spec file.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:19 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - A simple service to setup container storage
devices
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #6 from Daniel Walsh <dwalsh(a)redhat.com> ---
I have generated this pull request to fix the issues.
https://github.com/projectatomic/container-storage-setup/pull/213
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:50 a.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - A simple service to setup container storage
devices
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
Lokesh Mandvekar <lsm5(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Lokesh Mandvekar <lsm5(a)redhat.com> ---
https://raw.githubusercontent.com/projectatomic/container-storage-setup/m...
addresses issues in Comment 4.
Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:15 p.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - A simple service to setup container storage
devices
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #8 from Daniel Walsh <dwalsh(a)redhat.com> ---
Lokesh do I just close this pull request?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:28 a.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - A simple service to setup container storage
devices
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #9 from Jon Ciesla <limburgher(a)gmail.com> ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/container-storage-setup
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8 a.m.
New subject: [Bug 1427295] Review Request:
container-storage-setup - A simple service to setup container storage
devices
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
Daniel Walsh <dwalsh(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |CURRENTRELEASE
Last Closed| |2017-03-03 09:00:02
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2663
days inactive
2667
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
bugzilla＠redhat.com