Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
Summary: Review Request: pavucontrol: Volume control for Polypaudio Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: drzeus-bugzilla@drzeus.cx QAContact: fedora-package-review@redhat.com
Spec URL: http://homes.drzeus.cx/~drzeus/polypaudio/pavucontrol.spec SRPM URL: http://homes.drzeus.cx/~drzeus/polypaudio/pavucontrol-0.9.1-1.src.rpm Description: Polypaudio Volume Control (pavucontrol) is a simple GTK based volume control tool ("mixer") for the Polypaudio sound server. In contrast to classic mixer tools this one allows you to control both the volume of hardware devices and of each playback stream separately.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for Polypaudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
drzeus-bugzilla@drzeus.cx changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |195221
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
drzeus-bugzilla@drzeus.cx changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: pavucontrol:|Review Request: pavucontrol: |Volume control for |Volume control for |Polypaudio |PulseAudio
------- Additional Comments From drzeus-bugzilla@drzeus.cx 2006-07-09 07:56 EST ------- Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol-0.9.2-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From drzeus-bugzilla@drzeus.cx 2006-08-20 06:58 EST ------- Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol-0.9.3-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
Bug 195223 depends on bug 195221, which changed state.
Bug 195221 Summary: Review Request: pulseaudio: Improved Linux sound server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195221
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From bdpepple@ameritech.net 2006-09-06 19:42 EST ------- Quick note:
1. Desktop file handling does not conform to Fe guidelines. Refer to http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From drzeus-bugzilla@drzeus.cx 2006-09-08 01:10 EST ------- I read that portion of the guidelines as relating to the case of when you have to include a .desktop file yourself (i.e. when upstream doesn't have one). If not, I would have expected a "rm" somewhere in the script to first kill off the .desktop file the Makefiles have installed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From bdpepple@ameritech.net 2006-09-08 08:47 EST ------- You would simply add something like:
desktop-file-install --vendor fedora --delete-original \ --dir $RPM_BUILD_ROOT%{_datadir}/applications \ --add-category X-Fedora \ $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop
to the install section of your spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@leemhuis.info |rdieter@math.unl.edu OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From rdieter@math.unl.edu 2006-09-08 09:09 EST ------- So that the .desktop file (name) doesn't vary from upstream, I'd suggest using: --vendor="" instead.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From rdieter@math.unl.edu 2006-09-08 09:14 EST ------- spec looks clean,simple, just * MUST: add to %install section desktop-file-install \ --dir $RPM_BUILD_ROOT%{_datadir}/applications \ --add-category="X-Fedora" --vendor="" \ $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop
do that, and pending my confirmation for building in mock and rpmlint sanity checking, I'll APPROVE this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From drzeus-bugzilla@drzeus.cx 2006-09-08 17:00 EST ------- Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol-0.9.4-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From bdpepple@ameritech.net 2006-09-08 18:33 EST ------- (In reply to comment #6)
So that the .desktop file (name) doesn't vary from upstream, I'd suggest using: --vendor="" instead.
Rex, maybe I'm missing something here. Why does it matter if you are setting the vendor?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From rdieter@math.unl.edu 2006-09-08 18:58 EST -------
Why does it matter if you are setting the vendor?
What *matters* is that .desktop files not get renamed, and adding --vendor does just that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From bdpepple@ameritech.net 2006-09-08 19:18 EST ------- (In reply to comment #10)
Why does it matter if you are setting the vendor?
What *matters* is that .desktop files not get renamed, and adding --vendor does just that.
I was aware that adding the vendor changes the desktop filename, but I guess my question is why does it matter if the desktop file gets renamed? Plenty of packages in extras do it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From rdieter@math.unl.edu 2006-09-08 20:23 EST -------
why does it matter if the desktop file gets renamed?
Lots of reasons, one of which is menu editing.
Plenty of packages in extras do it.
I know, but they (mostly) shouldn't have. But, since the files were renamed once, they probably ought to stay that way (else we'd comitt the sin of renaming them *again*).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From drzeus-bugzilla@drzeus.cx 2006-09-09 07:17 EST ------- Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/pavucontrol-0.9.4-2.src.rpm
BR added.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From rdieter@math.unl.edu 2006-09-09 08:34 EST ------- One possible simplification is replace in %files: %dir %{_datadir}/pavucontrol %{_datadir}/pavucontrol/pavucontrol.glade with %{_datadir}/pavucontrol/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From rdieter@math.unl.edu 2006-09-09 08:36 EST ------- mock builds fine, rpmlint is happy: $rpmlint pavucontrol-0.9.4-2.fc6.i386.rpm 386.rpm W: pavucontrol incoherent-version-in-changelog 0.9.4-2 0.9.4-2.fc6
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
drzeus-bugzilla@drzeus.cx changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
lpoetter@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lpoetter@redhat.com Flag| |fedora-cvs?
------- Additional Comments From lpoetter@redhat.com 2007-07-30 13:34 EST ------- Package Change Request ====================== Package Name: pavucontrol Updated Fedora Owners: lpoetter@redhat.com,drzeus-bugzilla@drzeus.cx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
------- Additional Comments From lpoetter@redhat.com 2007-07-30 13:37 EST ------- Sorry, I forgot the justification for the owner change: I am upstream for this package and Pierre agreed to co-maintain this package with me from now on.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195223
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-07-30 13:37 EST ------- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pavucontrol: Volume control for PulseAudio
https://bugzilla.redhat.com/show_bug.cgi?id=195223
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla