https://bugzilla.redhat.com/show_bug.cgi?id=1649750
Bug ID: 1649750 Summary: Review Request: python-pyemd - Fast EMD for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sanjay.ankur@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd-0.5.1-1.fc29.s...
Description: PyEMD is a Python wrapper for Ofir Pele and Michael Werman’s implementation of the Earth Mover’s Distance that allows it to be used with NumPy. If you use this code, please cite the papers listed in the README.rst file.
Fedora Account System Username: ankursinha
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1619458 (python-pyphi), | |1276941 (fedora-neuro) Alias| |python-pyemd
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug https://bugzilla.redhat.com/show_bug.cgi?id=1619458 [Bug 1619458] Review Request: python-pyphi - A library for computing integrated information
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
BuildRequires: gcc gcc-c++
One-per-line please.
export PYTHONPATH=$RPM_BUILD_ROOT/%{python2_sitearch}
I think %{buildroot} is nowadays considered nicer, but this is acceptable of course.
+ package name is OK + latest version + license is acceptable for Fedora (MIT) + licencse is specified correctly + builds and installs OK + fedora-review is happy + R/BR/P look OK
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
--- Comment #2 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
BuildRequires: gcc gcc-c++
One-per-line please.
export PYTHONPATH=$RPM_BUILD_ROOT/%{python2_sitearch}
I think %{buildroot} is nowadays considered nicer, but this is acceptable of course.
Thanks for the review, Zbigniew! Updated both.
Spec URL: https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd-0.5.1-1.fc29.s...
(Didn't bump the release for these, but noted in changelog)
SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8834
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyemd
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- python-pyemd-0.5.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9f668c47ec
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-pyemd-0.5.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-12ea3cbd6f
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-pyemd-0.5.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9f668c47ec
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-pyemd-0.5.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-12ea3cbd6f
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-11-24 21:02:00
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-pyemd-0.5.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1649750
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-pyemd-0.5.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com