[Bug 248363] New: Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

Summary: Review Request: mpfr -  A C library for multiple-
                    precision floating-point computations
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://people.redhat.com/varekova/mpfr.spec
SRPM URL: http://people.redhat.com/varekova/mpfr-2.2.1-1.src.rpm
Description: 
The MPFR library is a C library for multiple-precision floating-point
computations with "correct rounding". The MPFR is efficient and
also has a well-defined semantics. It copies the good ideas from the
ANSI/IEEE-754 standard for double-precision floating-point arithmetic
(53-bit mantissa). MPFR is based on the GMP multiple-precision library.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|[e-mail]    |[e-mail]
  BugsThisDependsOn|                            |225809
               Flag|                            |fedora-review?, needinfo?

------- Additional Comments From [e-mail]  2007-07-16 12:19 EST -------
Good:
+ Package meets naming guildlines.
+ SPEC file name matches with package base name.
+ License tag says GPL
+ Project home page says LGPL as package license
+ Package contains verbatim copy of the license text
+ SPEC is written in English
+ SPEC file is legible
+ Tar ball matches with upstream
  (md5sum: 40bf06f8081461d8db7d6f4ad5b9f6bd)
+ Package has correct build root
+ BuildRequires are not redundant
+ Local build works fine.
+ package has %defattr an proper file permissions
+ %doc section is small
+ %doc section doesn't affect run time
+ Package contains no duplicates in the %file list
+ Changelog entries are ok.
+ Rpmlint is quite on source package.
+ Rpmlint is quite on binary packages
+ Mock build works fine for Devel (x86_64, i386, ppp64, ppc)

Bad:
- Package needs a Conflict tag, because the current gmp package contains the
mpfr package
- Unnecessary condition on deleting build root in %clean section
- Devel package contains static library

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-20 03:56 EST -------
Created an attachment (id=159633)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159633&action=vie...)
fixed srpm

Thanks for your review the attached srpm fixes bugs you mentioned.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-20 04:05 EST -------
*** Bug 248354 has been marked as a duplicate of this bug. ***

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?                   |

------- Additional Comments From [e-mail]  2007-07-20 04:24 EST -------
The mpfr library is released under LGPL2.1, how can saying it is GPL in the
License tag be a "Good" thing?  Of course you can relicense LGPL2.1 code as GPL,
but why would you do that?  License: LGPL would be much better (unless with the
advent of GPL3, LGPL3, LGPL2.5 we start being more explicit and write
GPL2, GPL2+, GPL3, GPL3+, LGPL2, LGPL2+, LGPL2.1, LGPL2.1+, LGPL2.5, LGPL3,
LGPL3+ etc. in License tags.

Also, upstream mpfr releases stable fixes on top of the last release
as a cummulative patch, see http://www.mpfr.org/mpfr-current/patches
It would be good to apply this in the spec file.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-20 04:53 EST -------
Created an attachment (id=159634)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159634&action=vie...)
fixed srpm (again)

Thanks Jakub, problems you mention are fixed in this version.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-21 07:07 EST -------
As far as I understand, that package cannot be push in Fedora, unless bug 
#225809 is closed, and libmpfr.a (and mpfr headers) removed from gmp-devel.

There is not a log of traffic in bug #225809. I do not even know if somebody 
is actually maintaining gmp (the version in Fedora is obsolete).

Ivana, what is your plan? Waiting for GMP maintainers to fix their package?

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-22 13:56 EST -------
(In reply to comment #6)
> As far as I understand, that package cannot be push in Fedora, unless bug 
> #225809 is closed, and libmpfr.a (and mpfr headers) removed from gmp-devel.

Yes, you right.
> There is not a log of traffic in bug #225809. I do not even know if somebody 
> is actually maintaining gmp (the version in Fedora is obsolete).
> Ivana, what is your plan? Waiting for GMP maintainers to fix their package?

We have to poke the gmp maintainer to do the split, because without the split 
we can't release a separate mpfr library.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-22 13:57 EST -------
(In reply to comment #6)
> As far as I understand, that package cannot be push in Fedora, unless bug 
> #225809 is closed, and libmpfr.a (and mpfr headers) removed from gmp-devel.

Yes, you right.
> There is not a log of traffic in bug #225809. I do not even know if somebody 
> is actually maintaining gmp (the version in Fedora is obsolete).
> Ivana, what is your plan? Waiting for GMP maintainers to fix their package?

We have to poke the gmp maintainer to do the split, because without the split 
we can't release a separate mpfr library.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-22 15:41 EST -------
I have create a suggestion for the gmp package on gmp-4.2.1.

So I thing, you should add a 'Conflict: gmp < 4.2.1' statement into your package.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-23 04:37 EST -------
Hello,
I'm gmp maintainer too so I'd like to update gmp in devel branch too, but I
don't want to remove mpfr files from gmp for long time without existence of the
separate mpfr package. So I plan to do both these changes (update gmp and remove
mpfr files from gmp and add mpfr package) when this review will be approved. 
I will update the conflict flag when I will build the new gmp version. 
Thanks for your comments.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-23 04:51 EST -------
Nice to hear that, Ivana. Do you have a gmp package updated, so that we can 
test it with the mpfr RPM of this bug?

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-23 08:28 EST -------
Created an attachment (id=159779)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159779&action=vie...)
proposed version of gmp package

Oops good idea - so this is the proposed version of gmp package.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-26 03:52 EST -------
Is there any other problem? Could somebody approved this package review please?
Thanks.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-26 09:47 EST -------
I'm waiting to see a package, where are complaints are fixed.

If I see this package, I will be able to approve your package.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

------- Additional Comments From [e-mail]  2007-07-26 10:03 EST -------
The srpm from comment #5 should have all fixes. Is there any problem with this
package? (perhaps I overlook some comment?)

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-07-26 10:39 EST -------
Soory for my mistake. I have got a look on it and it's looks fine.

*** YOU ARE APPROVED ***

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-07-26 10:47 EST -------
Package Name: mpfr 
Short Description: A C library for multiple-precision floating-point computations
Owners: [e-mail]
Branches:

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248363

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-08-06 10:27 EST -------
mpfr-2.2.1-1 package is just built. If there is any problem please create a
separate bug for this component.

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/show_bug.cgi?id=248363

Bug 248363 depends on bug 225809, which changed state.

Bug 225809 Summary: Merge Review: gmp
https://bugzilla.redhat.com/show_bug.cgi?id=225809

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpfr -  A C library for multiple-precision floating-point computations

https://bugzilla.redhat.com/show_bug.cgi?id=248363

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

Bug 248363 depends on bug 225809, which changed state.

Bug 225809 Summary: Merge Review: gmp
https://bugzilla.redhat.com/show_bug.cgi?id=225809

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|NEXTRELEASE                 |NOTABUG
             Status|CLOSED                      |ASSIGNED
         Resolution|NOTABUG                     |

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=248363

Bug 248363 depends on bug 225809, which changed state.

Bug 225809 Summary: Merge Review: gmp
https://bugzilla.redhat.com/show_bug.cgi?id=225809

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=248363

Bug 248363 depends on bug 225809, which changed state.

Bug 225809 Summary: Merge Review: gmp
https://bugzilla.redhat.com/show_bug.cgi?id=225809

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
         Resolution|RAWHIDE                     |

[Bug 248363] Review Request: mpfr - A C library for multiple-precision floating-point computations

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=248363

Bug 248363 depends on bug 225809, which changed state.

Bug 225809 Summary: Merge Review: gmp
https://bugzilla.redhat.com/show_bug.cgi?id=225809

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE