[Bug 1862618] New: Review Request: ocaml-ppx-cold - OCaml definition of [@@cold] attribute
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
Bug ID: 1862618 Summary: Review Request: ocaml-ppx-cold - OCaml definition of [@@cold] attribute Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-cold/ocaml-ppx-cold.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-cold/ocaml-ppx-cold-0.14.0-1.fc33.... Fedora Account System Username: jjames Description: Ppx_cold translates [@@cold] attributes to [@@inline never] [@@local never] [@@specialise never]. See the discussion in https://github.com/ocaml/ocaml/issues/8563.
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.cermak@cgc-instruments. | |com, rjones@redhat.com Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1862620
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1862620 [Bug 1862620] Review Request: ocaml-ppx-assert - Assert-like extension nodes that raise useful errors on failure
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1862627
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1862627 [Bug 1862627] Review Request: ocaml-ppx-base - Base set of OCaml ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jsmith.fedora@gmail.com Assignee|nobody@fedoraproject.org |jsmith.fedora@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #1 from Jared Smith jsmith.fedora@gmail.com --- Package is APPROVED. I'm not sure what the "This should never happen" warning in the OCaml section is about, however.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 11 files have unknown license. Detailed output of licensecheck in /home/jsmith/Documents/Fedora/Reviews/1862618-ocaml-ppx- cold/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Ocaml: [x]: This should never happen
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: ocaml-ppx-cold-0.14.0-1.fc33.x86_64.rpm ocaml-ppx-cold-devel-0.14.0-1.fc33.x86_64.rpm ocaml-ppx-cold-debuginfo-0.14.0-1.fc33.x86_64.rpm ocaml-ppx-cold-debugsource-0.14.0-1.fc33.x86_64.rpm ocaml-ppx-cold-0.14.0-1.fc33.src.rpm ocaml-ppx-cold.x86_64: W: spelling-error %description -l en_US specialise -> specialist, specialism, specialize ocaml-ppx-cold.src: W: spelling-error %description -l en_US specialise -> specialist, specialism, specialize 5 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (debuginfo) ------------------- Checking: ocaml-ppx-cold-debuginfo-0.14.0-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-cold.x86_64: W: spelling-error %description -l en_US specialise -> specialist, specialism, specialize ocaml-ppx-cold.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_cold <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-cold-devel.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_cold <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-cold-debuginfo.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_cold <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. ocaml-ppx-cold-debugsource.x86_64: W: invalid-url URL: https://github.com/janestreet/ppx_cold <urlopen error [Errno -3] Temporary failure in name resolution> 4 packages and 0 specfiles checked; 0 errors, 5 warnings.
Source checksums ---------------- https://github.com/janestreet/ppx_cold/archive/v0.14.0/ppx_cold-0.14.0.tar.g... : CHECKSUM(SHA256) this package : 9f6479fc16dd8a7cf534058c60e3ba331628e095a06a5e4418159f6ed445647f CHECKSUM(SHA256) upstream package : 9f6479fc16dd8a7cf534058c60e3ba331628e095a06a5e4418159f6ed445647f
Requires -------- ocaml-ppx-cold (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) ocaml(Ast_mapper) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Buffer) ocaml(Base__Buffer_intf) ocaml(Base__Bytes) ocaml(Base__Bytes_set_primitives) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Either0) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Identifiable) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Ppx_sexp_conv_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sexplib) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__Validate) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalMenhirLib) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Config) ocaml(Docstrings) ocaml(Lexer) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Migrate_parsetree) ocaml(Migrate_parsetree__) ocaml(Migrate_parsetree__Ast_402) ocaml(Migrate_parsetree__Ast_403) ocaml(Migrate_parsetree__Ast_404) ocaml(Migrate_parsetree__Ast_405) ocaml(Migrate_parsetree__Ast_406) ocaml(Migrate_parsetree__Ast_407) ocaml(Migrate_parsetree__Ast_408) ocaml(Migrate_parsetree__Ast_408_helper) ocaml(Migrate_parsetree__Ast_409) ocaml(Migrate_parsetree__Ast_409_helper) ocaml(Migrate_parsetree__Ast_410) ocaml(Migrate_parsetree__Ast_411) ocaml(Migrate_parsetree__Locations) ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions) ocaml(Migrate_parsetree__Migrate_parsetree_driver) ocaml(Migrate_parsetree__Migrate_parsetree_versions) ocaml(Migrate_parsetree__Option) ocaml(Migrate_parsetree__Stdlib0) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parse) ocaml(Parser) ocaml(Parsetree) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Name) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_traverse_builtins) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__) ocaml(Sexplib0__Lazy_group_id) ocaml(Sexplib0__Raw_grammar) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Sexplib0__Sexpable) ocaml(Shadow_stdlib) ocaml(Stdio) ocaml(Stdio__) ocaml(Stdio__Import) ocaml(Stdio__In_channel) ocaml(Stdio__Out_channel) ocaml(Stdlib) ocaml(Stdlib__arg) ocaml(Stdlib__array) ocaml(Stdlib__buffer) ocaml(Stdlib__digest) ocaml(Stdlib__format) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__int64) ocaml(Stdlib__lazy) ocaml(Stdlib__lexing) ocaml(Stdlib__list) ocaml(Stdlib__listLabels) ocaml(Stdlib__map) ocaml(Stdlib__moreLabels) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__parsing) ocaml(Stdlib__pervasives) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__seq) ocaml(Stdlib__set) ocaml(Stdlib__stdLabels) ocaml(Stdlib__string) ocaml(Stdlib__stringLabels) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Syntaxerr) ocaml(Type_immediacy) ocaml(Warnings) ocamlx(CamlinternalOO) rtld(GNU_HASH)
ocaml-ppx-cold-devel (rpmlib, GLIBC filtered): ocaml(Ast_mapper) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Buffer) ocaml(Base__Buffer_intf) ocaml(Base__Bytes) ocaml(Base__Bytes_set_primitives) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Either0) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Identifiable) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Ppx_sexp_conv_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sexplib) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__Validate) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalMenhirLib) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Config) ocaml(Docstrings) ocaml(Lexer) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Migrate_parsetree) ocaml(Migrate_parsetree__) ocaml(Migrate_parsetree__Ast_402) ocaml(Migrate_parsetree__Ast_403) ocaml(Migrate_parsetree__Ast_404) ocaml(Migrate_parsetree__Ast_405) ocaml(Migrate_parsetree__Ast_406) ocaml(Migrate_parsetree__Ast_407) ocaml(Migrate_parsetree__Ast_408) ocaml(Migrate_parsetree__Ast_408_helper) ocaml(Migrate_parsetree__Ast_409) ocaml(Migrate_parsetree__Ast_409_helper) ocaml(Migrate_parsetree__Ast_410) ocaml(Migrate_parsetree__Ast_411) ocaml(Migrate_parsetree__Locations) ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions) ocaml(Migrate_parsetree__Migrate_parsetree_driver) ocaml(Migrate_parsetree__Migrate_parsetree_versions) ocaml(Migrate_parsetree__Option) ocaml(Migrate_parsetree__Stdlib0) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parse) ocaml(Parser) ocaml(Parsetree) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Name) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_traverse_builtins) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__) ocaml(Sexplib0__Lazy_group_id) ocaml(Sexplib0__Raw_grammar) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Sexplib0__Sexpable) ocaml(Shadow_stdlib) ocaml(Stdio) ocaml(Stdio__) ocaml(Stdio__Import) ocaml(Stdio__In_channel) ocaml(Stdio__Out_channel) ocaml(Stdlib) ocaml(Stdlib__arg) ocaml(Stdlib__array) ocaml(Stdlib__buffer) ocaml(Stdlib__digest) ocaml(Stdlib__format) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__int64) ocaml(Stdlib__lazy) ocaml(Stdlib__lexing) ocaml(Stdlib__list) ocaml(Stdlib__listLabels) ocaml(Stdlib__map) ocaml(Stdlib__moreLabels) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__parsing) ocaml(Stdlib__pervasives) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__seq) ocaml(Stdlib__set) ocaml(Stdlib__stdLabels) ocaml(Stdlib__string) ocaml(Stdlib__stringLabels) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Syntaxerr) ocaml(Type_immediacy) ocaml(Warnings) ocaml-ppx-cold(x86-64) ocaml-ppxlib-devel(x86-64) ocamlx(CamlinternalOO)
ocaml-ppx-cold-debuginfo (rpmlib, GLIBC filtered):
ocaml-ppx-cold-debugsource (rpmlib, GLIBC filtered):
Provides -------- ocaml-ppx-cold: ocaml(Ppx_cold) ocaml-ppx-cold ocaml-ppx-cold(x86-64) ocamlx(Ppx_cold)
ocaml-ppx-cold-devel: ocaml(Ppx_cold) ocaml-ppx-cold-devel ocaml-ppx-cold-devel(x86-64) ocamlx(Ppx_cold)
ocaml-ppx-cold-debuginfo: debuginfo(build-id) ocaml-ppx-cold-debuginfo ocaml-ppx-cold-debuginfo(x86-64)
ocaml-ppx-cold-debugsource: ocaml-ppx-cold-debugsource ocaml-ppx-cold-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1862618 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++, Ocaml Disabled plugins: Java, SugarActivity, Haskell, fonts, R, PHP, Perl, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
--- Comment #2 from Jerry James loganjerry@gmail.com --- Thank you again, Jared!
(In reply to Jared Smith from comment #1)
Package is APPROVED. I'm not sure what the "This should never happen" warning in the OCaml section is about, however.
I have a vague memory of trying to figure that out once, after seeing it in an OCaml package review. The warning comes from /usr/share/fedora-review/plugins/ocaml.py:
class OcamlCheckStaticLibs(OcamlCheckBase): """ Disable static lib checking, ocaml has an exception. """
def __init__(self, checks): OcamlCheckBase.__init__(self, checks) self.automatic = True self.text = "This should never happen" self.deprecates.append("CheckStaticLibs")
def run_on_applicable(self): self.set_passed(self.PASS)
I don't know what happens to trigger it, though. Apparently something is going wrong with checking for static libraries, but the nature of that something is a mystery to me.
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppx-cold
https://bugzilla.redhat.com/show_bug.cgi?id=1862618
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2020-08-11 04:16:01
--- Comment #4 from Jerry James loganjerry@gmail.com --- Built in Rawhide.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com