[Bug 492797] New: Review Request: ofl-goudy-bookletter-1911-fonts - Clean serif font based on Kennerly Old Style
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ofl-goudy-bookletter-1911-fonts - Clean serif font based on Kennerly Old Style
https://bugzilla.redhat.com/show_bug.cgi?id=492797
Summary: Review Request: ofl-goudy-bookletter-1911-fonts - Clean serif font based on Kennerly Old Style Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tcallawa@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://www.auroralinux.org/people/spot/review/new/ofl-goudy-bookletter-1911-... SRPM URL: http://www.auroralinux.org/people/spot/review/new/ofl-goudy-bookletter-1911-... Description: Based on the roman of Frederic Goudy's Kennerley Old Style (designed and cut in 1911 for a limited edition of "The Door in the Wall and Other Stories" by H G Wells, published by Mitchell Kennerley). The letters, though not condensed, may seem to fit together like pieces of a jigsaw puzzle, giving text an unusually solid appearance.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492797
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |nicolas.mailhot@laposte.net Flag| |fedora-review?, | |needinfo?(tcallawa@redhat.c | |om)
--- Comment #1 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-03-30 15:15:41 EDT --- Initial review:
1. please use "oflb" not "ofl" as prefix, since OFL is already commonly used to identify a license the Open Font Library folks use OFLB to designate themselves
2. you have the wrong font name in your fontconfig file
3. you have some stray %defines, we're supposed to use %globals nowadays
4. %common_desc is not really useful for anything in a mono-font spec file, though I suppose it's harmless
5. your metadata declaration order is unusual, though it'll probably only annoy people diffing spec files
Nothing too difficult to fix for an experienced packager, and only 1 and 2 dangerous. Thank you for continuing to add fonts to Fedora.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492797
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(tcallawa@redhat.c | |om) |
--- Comment #2 from Tom "spot" Callaway tcallawa@redhat.com 2009-03-31 18:03:34 EDT --- Four out of five fixed:
New Spec URL: http://www.auroralinux.org/people/spot/review/new/oflb-goudy-bookletter-1911... New SRPM URL: http://www.auroralinux.org/people/spot/review/new/oflb-goudy-bookletter-1911...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492797
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nicolas.mailhot@laposte.net |tcallawa@redhat.com Flag|fedora-review? |fedora-review+
--- Comment #3 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-04-01 16:29:10 EDT --- This one is a go
⬬⬬⬬ APPROVED ⬬⬬⬬
You can now continue on from http://fedoraproject.org/wiki/Font_package_lifecycle#3.a
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492797
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
--- Comment #4 from Tom "spot" Callaway tcallawa@redhat.com 2009-04-01 16:50:39 EDT --- New Package CVS Request ======================= Package Name: oflb-goudy-bookletter-1911-fonts Short Description: Clean serif font based on Kennerly Old Style Owners: spot Branches: F-9 F-10 devel InitialCC: fonts-sig
... and it's done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492797
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #5 from Tom "spot" Callaway tcallawa@redhat.com 2009-04-01 17:17:56 EDT --- I branched it for F-9 and F-10, but it would not build for either target because the versions of fontforge on those branches does not have support for the python extensions (rawhide does). It is built in rawhide.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla