https://bugzilla.redhat.com/show_bug.cgi?id=1502016
Bug ID: 1502016 Summary: Review Request: deepin-picker - color picker tool for Deepin Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
Description: color picker tool for Deepin
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
--- Comment #1 from sensor.wen@gmail.com --- Today, Deepin have a new little project. Could you have free time to review it? @zebob
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Hello mosquito,
- update-desktop-database is not needed anymore in Fedora 25 or later. See https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...
Just use:
%post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi
%posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
- I don't think this dependency should be so strict:
BuildRequires: pkgconfig(dtkwidget) = 2.0
Maybe use >=.
- You must validate the .desktop file:
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop
- You must add the followinq Require for icons:
Requires: hicolor-icon-theme
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
--- Comment #3 from sensor.wen@gmail.com --- https://koji.fedoraproject.org/koji/taskinfo?taskID=22440296
Thank you for your work. I fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- All ok, package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-picker
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sztsian@gmail.com Alias| |deepin-picker
https://bugzilla.redhat.com/show_bug.cgi?id=1502016
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:32:17
--- Comment #6 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com