https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Bug ID: 1485722 Summary: Review Request: deepin-file-manager - Deepin File Manager Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
Description: Deepin File Manager
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |zebob.m@gmail.com Resolution|--- |WONTFIX Last Closed| |2017-08-27 13:03:24
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- mpv-libs-devel is not available through normal Fedora repositories. It is available on RPMFusion though, so you should probably propose this package there.
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|WONTFIX |--- Keywords| |Reopened
--- Comment #2 from sensor.wen@gmail.com --- https://github.com/linuxdeepin/dde-file-manager/issues/60
I have told the upstream that provides an option to disable MPV.
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Robin Lee robinlee.sysu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |robinlee.sysu@gmail.com Whiteboard| |NotReady
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
--- Comment #3 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
Removed mpv dependency
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- BuildRequires: pkgconfig(libffmpegthumbnailer)
is also only available on RPMFusion.
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Robin Lee robinlee.sysu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1483300
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1483300 [Bug 1483300] Review Request: deepin-qt5integration - Qt platform theme integration plugins for DDE
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1483300 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1483300 [Bug 1483300] Review Request: deepin-qt5integration - Qt platform theme integration plugins for DDE
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
--- Comment #5 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
Disable ffmpeg
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #6 from Robert-André Mauchin zebob.m@gmail.com --- Hello,
There's a couple of typo, it doesn't break anything but are kind of annoying for comprehension:
- first the name of the patch:
deepin-file-manager-diable_ffmpeg.patch → deepin-file-manager-disable_ffmpeg.patch
- then inside of the patch itself:
SUPPORT_FFMEPG → SUPPORT_FFMPEG
- There are several issue regarding ownership of directories:
/usr/lib64/dde-dock /usr/lib64/dde-dock/plugins /usr/lib64/dde-file-manager /usr/lib64/dde-file-manager/plugins /usr/lib64/dde-file-manager/plugins/previews
/usr/share/dde-desktop /usr/share/dde-desktop/translations /usr/share/dman /usr/share/usb-device-formatter /usr/share/usb-device-formatter/translations
/usr/include/dde-file-manager /usr/include/dde-file-manager/dde-file-manager-plugins /usr/include/dde-file-manager/gvfs /usr/include/dde-file-manager/private
All those dirs are created by your package but aren't owned. Please add a %dir macro for each one.
- You forgot to call desktop-file-validate on your desktop files:
%check desktop-file-validate %{buildroot}/%{_datadir}/applications/%{repo}.desktop desktop-file-validate %{buildroot}/%{_datadir}/applications/dde-computer.desktop desktop-file-validate %{buildroot}/%{_datadir}/applications/dde-trash.desktop
- Also I couldn't install the package because it depends on deepin-manual, which I don't have. And is it really necessary to make a file manager depends on the manual?
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file.
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "Unicode strict", "MIT/X11 (BSD like)", "LGPL (v2.1)", "BSD (3 clause)". 1645 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/deepin-file-manager/review- deepin-file-manager/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/dde-desktop/translations, /usr/lib64/dde-file-manager/plugins, /usr/lib64/dde-dock/plugins, /usr/include/dde-file-manager/private, /usr/lib64/dde-file-manager, /usr/share/usb-device-formatter, /usr/lib64/dde-file- manager/plugins/previews, /usr/share/dde-desktop, /usr/include/dde- file-manager, /usr/share/dman, /usr/include/dde-file-manager/gvfs, /usr/lib64/dde-dock, /usr/share/usb-device-formatter/translations, /usr/include/dde-file-manager/dde-file-manager-plugins [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/usb-device- formatter/translations, /usr/lib64/dde-dock, /usr/share/dde-desktop, /usr/share/dbus-1/system-services, /usr/include/dde-file-manager/gvfs, /usr/share/dbus-1, /etc/dbus-1, /usr/share/dbus-1/interfaces, /usr/include/dde-file-manager, /usr/lib64/dde-dock/plugins, /usr/include/dde-file-manager/private, /usr/lib64/dde-file- manager/plugins, /usr/lib64/dde-file-manager, /usr/share/usb-device- formatter, /etc/dbus-1/system.d, /usr/share/dde-desktop/translations, /usr/share/dbus-1/services, /usr/include/dde-file-manager/dde-file- manager-plugins, /usr/lib64/dde-file-manager/plugins/previews, /usr/share/dman [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in deepin-file-manager [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in deepin-file-manager [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in deepin- file-manager-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2938880 bytes in /usr/share [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: deepin-file-manager-4.2.5-1.fc28.x86_64.rpm deepin-file-manager-devel-4.2.5-1.fc28.x86_64.rpm deepin-desktop-4.2.5-1.fc28.x86_64.rpm deepin-file-manager-debuginfo-4.2.5-1.fc28.x86_64.rpm deepin-file-manager-4.2.5-1.fc28.src.rpm deepin-file-manager.x86_64: W: hidden-file-or-dir /usr/lib/.build-id deepin-file-manager.x86_64: W: hidden-file-or-dir /usr/lib/.build-id deepin-file-manager.x86_64: E: zero-length /usr/share/dde-file-manager/mimetypes/audio.mimetype deepin-file-manager.x86_64: E: zero-length /usr/share/dde-file-manager/mimetypes/image.mimetype deepin-file-manager.x86_64: E: zero-length /usr/share/dde-file-manager/templates/newTxt.txt deepin-file-manager.x86_64: W: no-manual-page-for-binary dde-file-manager deepin-file-manager.x86_64: W: no-manual-page-for-binary dde-file-manager-daemon deepin-file-manager.x86_64: W: no-manual-page-for-binary dde-file-manager-pkexec deepin-file-manager.x86_64: W: no-manual-page-for-binary dde-property-dialog deepin-file-manager.x86_64: W: no-manual-page-for-binary dde-xdg-user-dirs-update.sh deepin-file-manager.x86_64: W: no-manual-page-for-binary usb-device-formatter deepin-file-manager.x86_64: W: no-manual-page-for-binary usb-device-formatter-pkexec deepin-file-manager-devel.x86_64: W: only-non-binary-in-usr-lib deepin-file-manager-devel.x86_64: W: no-documentation deepin-desktop.x86_64: W: only-non-binary-in-usr-lib deepin-desktop.x86_64: W: no-documentation deepin-desktop.x86_64: W: hidden-file-or-dir /usr/lib/.build-id deepin-desktop.x86_64: W: hidden-file-or-dir /usr/lib/.build-id deepin-desktop.x86_64: W: no-manual-page-for-binary dde-desktop deepin-desktop.x86_64: E: invalid-desktopfile /usr/share/applications/dde-computer.desktop value "Deepin;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Deepin"; values extending the format should start with "X-" deepin-desktop.x86_64: W: desktopfile-without-binary /usr/share/applications/dde-computer.desktop gvfs-open deepin-desktop.x86_64: E: invalid-desktopfile /usr/share/applications/dde-trash.desktop value "Deepin;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Deepin"; values extending the format should start with "X-" deepin-desktop.x86_64: W: desktopfile-without-binary /usr/share/applications/dde-trash.desktop gvfs-open 5 packages and 0 specfiles checked; 5 errors, 18 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
--- Comment #7 from sensor.wen@gmail.com --- https://github.com/FZUG/repo/commit/a9f6b85bb31d085ef5ab1b0295c4ecc91c7ae432
Fixed. Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #8 from Robert-André Mauchin zebob.m@gmail.com --- Perfect, package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
--- Comment #9 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-file-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sztsian@gmail.com Alias| |deepin-file-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed|2017-08-27 13:03:24 |2018-07-22 09:30:58
--- Comment #10 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com