Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: maven-parent - Apache Maven parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=715583
Summary: Review Request: maven-parent - Apache Maven parent POM Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sochotni@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://sochotni.fedorapeople.org/packages/maven-parent.spec SRPM URL: http://sochotni.fedorapeople.org/packages/maven-parent-20-1.fc15.src.rpm
Description: Apache Maven parent POM file used by other Maven projects.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715583
Jaromír Cápík jcapik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jcapik@redhat.com AssignedTo|nobody@fedoraproject.org |jcapik@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715583
Jaromír Cápík jcapik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Jaromír Cápík jcapik@redhat.com 2011-06-23 10:09:37 EDT --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Rpmlint output:
$ rpmlint maven-parent-20-1.fc15.noarch.rpm maven-parent.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-parent 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint maven-parent-20-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license.
License type: ASL 2.0
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package : 17ff30d589be8948285fe34fbea74899 MD5SUM upstream package : 17ff30d589be8948285fe34fbea74899
[x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [-] Javadoc documentation files are generated and included in -javadoc subpackage [-] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [-] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [-] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [-] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly)
NOTE: add_maven_depmap used instead ... it's OK since it's gonna be a part of new guidelines
=== Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why it's needed in a comment [x] Package uses %update_maven_depmap in %post/%postun [x] Packages have Requires(post) and Requires(postun) on jpackage-utils (for %update_maven_depmap macro)
=== Other suggestions === [-] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock.
Tested on: fedora-rawhide-x86_64
================ *** APPROVED *** ================
[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines [2] https://fedoraproject.org/wiki/Packaging:Guidelines [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines [4] https://fedoraproject.org/wiki/Licensing:Main [5] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 [6] https://fedoraproject.org/wiki/Packaging:Java#Filenames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715583
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Stanislav Ochotnicky sochotni@redhat.com 2011-06-23 10:12:39 EDT --- New Package SCM Request ======================= Package Name: maven-parent Short Description: Apache Maven parent POM Owners: sochotni Branches: InitialCC: java-sig
Thanks for the review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715583
--- Comment #3 from Jon Ciesla limb@jcomserv.net 2011-06-23 10:48:53 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715583
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-06-23 11:07:19
--- Comment #4 from Stanislav Ochotnicky sochotni@redhat.com 2011-06-23 11:07:19 EDT --- Package built: http://koji.fedoraproject.org/koji/taskinfo?taskID=3155320
Thanks for the quick repo
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla