[Bug 1485566] New: Review Request: libmseed - A C library framework for manipulating and managing SEED data records
9:34 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
Bug ID: 1485566
Summary: Review Request: libmseed - A C library framework for
manipulating and managing SEED data records
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: quantum.analyst(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://qulogic.fedorapeople.org/obspy/libmseed.spec
SRPM URL: https://qulogic.fedorapeople.org/obspy/libmseed-2.19.4-2.fc26.src.rpm
Description: The Mini-SEED library provides a framework for manipulation of
SEED data records including the unpacking and packing of data records.
Functionality is also included for managing waveform data as continuous traces.
All structures of SEED 2.4 data records are supported with the following
exceptions: Blockette 2000 opaque data which has an unknown data structure by
definition and Blockette 405 which depends on full SEED (SEED including full
ASCII headers) for a full data description.
Fedora Account System Username: qulogic
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21474114
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:49 a.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Hello,
You could switch make %{?_smp_mflags} for %make_build and make \
DESTDIR=%{buildroot} for %make_install
It seems the License LGPLv3+, not LPGLv2+.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v3.0)", "LGPL (v3 or later)", "Unknown or
generated".
164 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/libmseed/review-libmseed/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 102400 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libmseed-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: libmseed-2.19.4-2.fc28.x86_64.rpm
libmseed-devel-2.19.4-2.fc28.x86_64.rpm
libmseed-debuginfo-2.19.4-2.fc28.x86_64.rpm
libmseed-2.19.4-2.fc28.src.rpm
libmseed.x86_64: W: spelling-error %description -l en_US Blockette -> Locket
libmseed.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
libmseed.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
libmseed.x86_64: W: no-manual-page-for-binary msrepack
libmseed.x86_64: W: no-manual-page-for-binary msview
libmseed-devel.x86_64: W: only-non-binary-in-usr-lib
libmseed.src: W: spelling-error %description -l en_US Blockette -> Locket
4 packages and 0 specfiles checked; 0 errors, 7 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:34 p.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
--- Comment #2 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
Huh, I must have forgotten to update the license when that was done.
Spec URL: https://qulogic.fedorapeople.org/obspy/libmseed.spec
SRPM URL: https://qulogic.fedorapeople.org/obspy/libmseed-2.19.4-3.fc26.src.rpm
Description: The Mini-SEED library provides a framework for manipulation of
SEED data records including the unpacking and packing of data records.
Functionality is also included for managing waveform data as continuous traces.
All structures of SEED 2.4 data records are supported with the following
exceptions: Blockette 2000 opaque data which has an unknown data structure by
definition and Blockette 405 which depends on full SEED (SEED including full
ASCII headers) for a full data description.
Fedora Account System Username: qulogic
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21502088
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:53 p.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
--- Comment #3 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
One more small tweak; add explicit BRs on C stuff; fedora-review is still
following old guidelines about this one.
Spec URL: https://qulogic.fedorapeople.org/obspy/libmseed.spec
SRPM URL: https://qulogic.fedorapeople.org/obspy/libmseed-2.19.4-4.fc26.src.rpm
Description: The Mini-SEED library provides a framework for manipulation of
SEED data records including the unpacking and packing of data records.
Functionality is also included for managing waveform data as continuous traces.
All structures of SEED 2.4 data records are supported with the following
exceptions: Blockette 2000 opaque data which has an unknown data structure by
definition and Blockette 405 which depends on full SEED (SEED including full
ASCII headers) for a full data description.
Fedora Account System Username: qulogic
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21504875
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:14 a.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
BuildRequires: make is not needed, even with the new guidelines
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:01 p.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
--- Comment #5 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
make was removed from the minimal buildroot though:
https://pagure.io/packaging-committee/issue/490 I don't really know where this
buildroot is defined though, so better to be explicit.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:31 p.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
--- Comment #6 from Gwyn Ciesla <limburgher(a)gmail.com> ---
(fedrepo-req-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/libmseed
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:54 a.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |ON_QA
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
libmseed-2.19.4-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dfbc7d9850
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:50 p.m.
New subject: [Bug 1485566] Review Request:
libmseed - A C library framework for manipulating and managing SEED data
records
https://bugzilla.redhat.com/show_bug.cgi?id=1485566
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2017-09-09 19:50:10
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
libmseed-2.19.4-4.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2479
days inactive
2493
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
bugzilla＠redhat.com