[Bug 710517] New: Review Request: gnome-shell-extension-remove-accessibility-icon - A gnome-shell extension for removing the accessibility icon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gnome-shell-extension-remove-accessibility-icon - A gnome-shell extension for removing the accessibility icon
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Summary: Review Request: gnome-shell-extension-remove-accessibility-icon - A gnome-shell extension for removing the accessibility icon Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-remove-acce... SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-remove-acce...
Project URL: http://martin-weusten.de/projects/gnomeshell-extensions/remove-accessibility...
Description: This simple extension does nothing more than to remove the accessibility icon in the top right corner of the GNOME panel.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3108677
rpmlint output: [fab@laptop021 SRPMS]$ rpmlint gnome-shell-extension-remove-accessibility-icon* gnome-shell-extension-remove-accessibility-icon.src: W: invalid-license GPL 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[fab@laptop021 noarch]$ rpmlint gnome-shell-extension-remove-accessibility-icon* gnome-shell-extension-remove-accessibility-icon.noarch: W: invalid-license GPL gnome-shell-extension-remove-accessibility-icon.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Upstream was asked about the license. So far no answer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Clint Savage herlo1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |herlo1@gmail.com AssignedTo|nobody@fedoraproject.org |herlo1@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
--- Comment #1 from Clint Savage herlo1@gmail.com 2011-06-04 09:04:39 EDT --- Licensing issue seems to be the only hold-up.
Builds just fine in mock.
$ rpmlint rpmbuild/SPECS/gnome-shell-extension-remove-accessibility-icon.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
spec file looks clean
$ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-shell-extension-remove-accessibility-icon-20110529-1.fc15.noarch.rpm gnome-shell-extension-remove-accessibility-icon.noarch: W: invalid-license GPL gnome-shell-extension-remove-accessibility-icon.noarch: W: no-documentation
SHOULD at least include a README and/or manual page.
Just update here when the licensing is sorted and I'll do another review.
Cheers,
Clint
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2011-06-04 09:39:07 EDT --- Thanks for your help, Clint.
(In reply to comment #1)
Licensing issue seems to be the only hold-up.
License is BSD. Upstream added licensing information to the source.
SHOULD at least include a README and/or manual page.
Upstream added a COPYING and a README file.
* Sat Jun 04 2011 Fabian Affolter fabian@bernewireless.net - 20110603-1 - README and COPYING added - License is Modified BSD License
Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-remove-acce... SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-remove-acce...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Clint Savage herlo1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Clint Savage herlo1@gmail.com 2011-06-04 12:31:23 EDT --- $ rpmlint /tmp/gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint ~/rpmbuild/SPECS/gnome-shell-extension-remove-accessibility-icon.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
License stated as BSD in COPYING, good to go.
Package approved.
Clint
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-cvs?
--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2011-06-04 13:23:27 EDT --- New Package VCS Request ======================= Package Name: gnome-shell-extension-remove-accessibility-icon Short Description: A gnome-shell extension for removing the accessibility icon Owners: fab Branches: F15 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
spider@alternating.net spider@gnome.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |spider@gnome.org
--- Comment #5 from spider@alternating.net spider@gnome.org 2011-06-04 16:21:46 EDT --- The one thing I have to say against this is that it removes the accessibility icon for all users without a chance to restore it, which is a bit of a bummer in a shared environment. But for a home user, that shouldn't be an issue.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limb@jcomserv.net
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2011-06-05 18:43:33 EDT --- New Package SCM Request ======================= Package Name: gnome-shell-extension-remove-accessibility-icon Short Description: A gnome-shell extension for removing the accessibility icon Owners: fab Branches: f15 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-06-05 18:44:03 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-06-06 14:12:06 EDT --- gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-shell-extension-remove-accessi...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-06-07 00:38:28 EDT --- gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-06-15 01:49:22 EDT --- gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |gnome-shell-extension-remov | |e-accessibility-icon-201106 | |03-1.fc15 Resolution| |ERRATA Last Closed| |2011-06-15 01:49:27
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
--- Comment #11 from Robert 'Bob' Jensen bob@fedoraunity.org 2011-06-16 08:57:17 EDT --- yum search returns the following short description "gnome-shell-extension-remove-accessibility-icon.noarch : A gnome-shell extensions for removing the accessibility icon" extensions should be changed to extension.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710517
Jeremias Nunez jereman_gnr@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jereman_gnr@hotmail.com
--- Comment #12 from Jeremias Nunez jereman_gnr@hotmail.com 2011-10-19 23:50:17 EDT --- not working in fedora 16 beta, it crashes gnome shell
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla