[Bug 1662534] New: Review Request: liquidctl - A tool for controlling NZXT liquid coolers, fans, and LED strips
8:06 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
Bug ID: 1662534
Summary: Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: fedora(a)svgames.pl
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
spec: https://svgames.pl/fedora/liquidctl-1.1.0-1.spec
srpm: https://svgames.pl/fedora/liquidctl-1.1.0-1.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=31716192
Description: liquidctl is a tool for controlling various settings of NZXT
devices, such as: liquid cooler pump speed, case fan speed, and colors of RGB
LED strips.
Fedora Account System Username: suve
This is my first time packaging python stuff, so it's rather unlikely there
aren't any issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:39 a.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |decathorpe(a)gmail.com
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Fabio Valentini <decathorpe(a)gmail.com> ---
Taking this review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:16 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #2 from Fabio Valentini <decathorpe(a)gmail.com> ---
I have some initial comments:
- This is a pure-python package, so it must have "BuildArch: noarch".
This also means you have can drop the "global debug_package %{nil}".
- "Requires: python3" should be automatically generated, you don't need to
specify it.
- "BuildRequires: python3-devel" includes "BuildRequires: python3", so
you can
drop the latter, too.
- This project has its sources published on pypi, you could use the official
release tarball from there instead of the github tag archive.
- Is the python package supposed to be imported by other scripts other than
"liquidctl" that's shipped with this package?
If so, you should consider splitting it off into a python3-liquidctl
sub-package.
PS: I found that "pyp2rpm" is a really good tool for creating python packages
for fedora - its output usually only requires minor edits for compliant fedora
packages.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:15 a.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #3 from Artur Iwicki <fedora(a)svgames.pl> ---
Thanks! I addressed most of the points. I don't think the package is _intended_
to be imported by other scripts, but the code is written clean and modular
enough that it definitely can be used this way.
spec: https://svgames.pl/fedora/liquidctl-1.1.0-2.spec
srpm: https://svgames.pl/fedora/liquidctl-1.1.0-2.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=31837304
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:13 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #4 from Fabio Valentini <decathorpe(a)gmail.com> ---
Package looks good now, with the exception of the wrong filename for the .spec
file:
Note: liquidctl-1.1.0-2.spec should be liquidctl.spec
Please fix that before importing the package. It would result in broken koji
builds, AFAIK.
Also, "BuildArch: noarch" propagates from the main package to sub-packages, so
specifying it twice isn't necessary - but it doesn't hurt, either, I guess.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:13 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com> ---
And, I forgot to mention: Remove the executable bit from the .spec file, too.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:28 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #6 from Artur Iwicki <fedora(a)svgames.pl> ---
Thanks, I'll keep these in mind.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:33 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #7 from Gwyn Ciesla <limburgher(a)gmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/liquidctl
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:24 a.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |MODIFIED
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
liquidctl-1.1.0-2.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-49bdb318d4
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:24 a.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
liquidctl-1.1.0-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-bd6d076007
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:49 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
liquidctl-1.1.0-2.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-bd6d076007
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:15 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org> ---
liquidctl-1.1.0-2.fc29 has been pushed to the Fedora 29 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-49bdb318d4
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:37 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2019-01-18 01:37:56
--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org> ---
liquidctl-1.1.0-2.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:13 p.m.
New subject: [Bug 1662534] Review Request: liquidctl - A tool for controlling
NZXT liquid coolers, fans, and LED strips
https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #13 from Fedora Update System <updates(a)fedoraproject.org> ---
liquidctl-1.1.0-2.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1950
days inactive
1970
days old
package-review@lists.fedoraproject.org
13 comments
1 participants
participants (1)
-
bugzilla＠redhat.com