[Bug 598422] New: Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

https://bugzilla.redhat.com/show_bug.cgi?id=598422

Summary: Review Request: maven-idea-plugin - Maven plugin to
                    support IntelliJ projects
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://sochotni.fedorapeople.org/maven-idea-plugin-2.2-1.fc13.src.rpm
SRPM URL: http://sochotni.fedorapeople.org/maven-idea-plugin.spec

Description: 
The IDEA Plugin is used to generate files (ipr, iml, and iws) for a
project so you can work on it using the IDE, IntelliJ IDEA.

[Bug 598422] Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598422

--- Comment #1 from Stanislav Ochotnicky  2010-06-01 07:49:31 EDT ---
Forgot to specify that this has dependencies that are for now only available in
dist-f14-maven221 target

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2221971

[Bug 598422] Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598422

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #2 from Alexander Kurtakov  2010-06-01 15:47:49 EDT ---
I'm taking this one.

[Bug 598422] Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598422

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Alexander Kurtakov  2010-06-01 15:54:45 EDT ---
Review:

OK: rpmlint must be run on every package. Output:
maven-idea-plugin.noarch: W: spelling-error %description -l en_US ipr -> pr,
rip, ppr
maven-idea-plugin.noarch: W: spelling-error %description -l en_US iml -> mil,
ml, isl
maven-idea-plugin.noarch: W: spelling-error %description -l en_US iws -> is,
ins, its
maven-idea-plugin.noarch: W: no-documentation
maven-idea-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-idea-plugin

False positives.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8.    
OK: Provides/Obsoletes are good.

Package is in a really good shape.

This package is APPROVED.

[Bug 598422] Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598422

Stanislav Ochotnicky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Stanislav Ochotnicky  2010-06-02 04:36:07 EDT ---
Thanks for the review. Requesting CVS:

New Package CVS Request
=======================
Package Name: maven-idea-plugin
Short Description: Plugin to support integration with IntelliJ IDEA projects
Owners: sochotni 
Branches: 
InitialCC:

[Bug 598422] Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598422

--- Comment #5 from Kevin Fenzi  2010-06-03 16:33:58 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 598422] Review Request: maven-idea-plugin - Maven plugin to support IntelliJ projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598422

Stanislav Ochotnicky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #6 from Stanislav Ochotnicky  2010-06-04 03:22:00 EDT ---
Package built:

https://koji.fedoraproject.org/koji/buildinfo?buildID=176555

Thanks and closing